Skip to content

Conversation

@apupier
Copy link
Contributor

@apupier apupier commented Aug 20, 2024

package

camel-cloud component was deprecated in 4.7.0, these packages need also to be deprecated

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

package

camel-cloud component was deprecated in 4.7.0, these packages need also
to be deprecated

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably use @Deprecated(since = "4.7.0") if they should have been deprecated in the last version, but I'm fine with either way.

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@apupier
Copy link
Contributor Author

apupier commented Aug 20, 2024

I'd probably use @Deprecated(since = "4.7.0") if they should have been deprecated in the last version, but I'm fine with either way.

I had this dilemna effectively. I feel like it is slightly better with the real moment it is marked as deprecated in the code base.

@apupier apupier merged commit 61a00d5 into apache:main Aug 20, 2024
@apupier apupier deleted the 20804-MARKdEPRECATIONaLSOiNcAMELcOREapi branch May 26, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants