Spring WS docs and code cleanup.#15382
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
| addEndpointDispatcherToConfiguration(configuration, lookupKey); | ||
| } else { | ||
| addEndpointMappingToConfiguration(parameters, configuration); | ||
| if (type.equals(EndpointMappingType.XPATHRESULT)) { |
There was a problem hiding this comment.
it seem this code is moved into this else block which was not the case before.
There was a problem hiding this comment.
You are correct, but this block will only execute if the branch where it is now is executed anyway, so I moved them together.
There was a problem hiding this comment.
A bit of a nitpick, but ideally it should be on a separate commit, as it prevents us from cherry-picking the doc changes to 4.4.x if we would like to.
|
orpiske
left a comment
orpiske
left a comment
There was a problem hiding this comment.
Those are great changes.
IMHO it would be better to have them on separate commits, so we can cherry-pick changes if we want to.
|
@ammachado there are 2 modified files. If you run mvn clean install in the folder then it would update those files. |
|
My local build has some failing tests on |
|
I added a PR on Spring-WS to upgrade WSS4J as well and match the version used in Camel spring-projects/spring-ws#1429. |
3 participants
Description
This PR adds small changes to the Spring-WS component documentation, as well as it applies the
instanceof patterncleanup a few times.Target
camel-3.x, whereas Camel 4 uses themainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.