feat(jbang): make export reproducible#15651
Merged
squakez merged 1 commit intoapache:mainfrom Sep 24, 2024
Merged
Conversation
Added a build propertues required as specified in https://maven.apache.org/guides/mini/guide-reproducible-builds.html
oscerd
approved these changes
Sep 24, 2024
davsclaus
approved these changes
Sep 24, 2024
Contributor
|
I wonder if adding a boolean option so users can turn this off of not desired |
Contributor
Author
I can do that but it would be complicating the export subcommand with yet another option. IMO this should be a best practice we enforce since prototype as it neither have any side effect on the final build. |
Contributor
Yeah its something that can always be added later, so its good as-is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a build propertues required as specified in https://maven.apache.org/guides/mini/guide-reproducible-builds.html
Description
Target
camel-3.x, whereas Camel 4 uses themainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.