Skip to content

feat(jbang): make export reproducible#15651

Merged
squakez merged 1 commit intoapache:mainfrom
squakez:feat/reproducible_export
Sep 24, 2024
Merged

feat(jbang): make export reproducible#15651
squakez merged 1 commit intoapache:mainfrom
squakez:feat/reproducible_export

Conversation

@squakez
Copy link
Contributor

@squakez squakez commented Sep 23, 2024

Added a build propertues required as specified in https://maven.apache.org/guides/mini/guide-reproducible-builds.html

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@davsclaus
Copy link
Contributor

I wonder if adding a boolean option so users can turn this off of not desired

@squakez
Copy link
Contributor Author

squakez commented Sep 24, 2024

I wonder if adding a boolean option so users can turn this off of not desired

I can do that but it would be complicating the export subcommand with yet another option. IMO this should be a best practice we enforce since prototype as it neither have any side effect on the final build.

@davsclaus
Copy link
Contributor

I wonder if adding a boolean option so users can turn this off of not desired

I can do that but it would be complicating the export subcommand with yet another option. IMO this should be a best practice we enforce since prototype as it neither have any side effect on the final build.

Yeah its something that can always be added later, so its good as-is

@squakez squakez merged commit 2f01892 into apache:main Sep 24, 2024
@squakez squakez deleted the feat/reproducible_export branch September 24, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants