Skip to content

CAMEL-21280: azure-files: Only CredentialType.SHARED_ACCOUNT_KEY is handled#15727

Merged
davsclaus merged 3 commits intoapache:mainfrom
s-clauw:main
Sep 26, 2024
Merged

CAMEL-21280: azure-files: Only CredentialType.SHARED_ACCOUNT_KEY is handled#15727
davsclaus merged 3 commits intoapache:mainfrom
s-clauw:main

Conversation

@s-clauw
Copy link
Contributor

@s-clauw s-clauw commented Sep 26, 2024

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor finding.

@s-clauw
Copy link
Contributor Author

s-clauw commented Sep 26, 2024

Not sure how the merge to 4.8.x will be done, is it by you or should I also do it there?

@oscerd
Copy link
Contributor

oscerd commented Sep 26, 2024

We'll backport on 4.8.x

@s-clauw s-clauw requested a review from oscerd September 26, 2024 15:50
@davsclaus davsclaus merged commit b8e6507 into apache:main Sep 26, 2024
davsclaus pushed a commit that referenced this pull request Sep 26, 2024
…andled (#15727)

* CAMEL-21280: azure-files: Only CredentialType.SHARED_ACCOUNT_KEY is handled

* CAMEL-21280 add unit test

* CAMEL-21280: Add license & code formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants