Use specific tag of minio container for Integration tests#15961
Merged
apupier merged 1 commit intoapache:mainfrom Oct 15, 2024
Merged
Use specific tag of minio container for Integration tests#15961apupier merged 1 commit intoapache:mainfrom
apupier merged 1 commit intoapache:mainfrom
Conversation
Using latest is making the build potentially break on external changes. In this case, the latest push is missing s390x architecture. See minio/minio#20560 it allows to fix tests on main branch Signed-off-by: Aurélien Pupier <apupier@redhat.com>
oscerd
approved these changes
Oct 15, 2024
Contributor
Author
|
for information, s390x is deprecated for minio minio/minio#20560 (comment) So etiher we start skipping IT tests on s390x or we pin to latest available with s390x for a while and upgrade to latest tag for other architectures. (can be done in another PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using latest is making the build potentially break on external changes. In this case, the latest push is missing s390x architecture. See minio/minio#20560
it allows to fix tests on main branch https://ci-builds.apache.org/job/Camel/job/Camel%20Core%20(Build%20and%20test)/job/main/lastCompletedBuild/testReport/org.apache.camel.component.minio.integration/MinioConsumerIT/BuildAndTest___Matrix___JDK_NAME____jdk_17_latest___PLATFORM____s390x____Test______/
Description
Target
camel-3.x, whereas Camel 4 uses themainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.