Skip to content

Use specific tag of minio container for Integration tests#15961

Merged
apupier merged 1 commit intoapache:mainfrom
apupier:fixMainBranch-minioLatestNotPushedFors390x
Oct 15, 2024
Merged

Use specific tag of minio container for Integration tests#15961
apupier merged 1 commit intoapache:mainfrom
apupier:fixMainBranch-minioLatestNotPushedFors390x

Conversation

@apupier
Copy link
Contributor

@apupier apupier commented Oct 15, 2024

Using latest is making the build potentially break on external changes. In this case, the latest push is missing s390x architecture. See minio/minio#20560

it allows to fix tests on main branch https://ci-builds.apache.org/job/Camel/job/Camel%20Core%20(Build%20and%20test)/job/main/lastCompletedBuild/testReport/org.apache.camel.component.minio.integration/MinioConsumerIT/BuildAndTest___Matrix___JDK_NAME____jdk_17_latest___PLATFORM____s390x____Test______/

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Using latest is making the build potentially break on external changes.
In this case, the latest push is missing s390x architecture. See
minio/minio#20560

it allows to fix tests on main branch

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
Copy link
Contributor Author

apupier commented Oct 15, 2024

for information, s390x is deprecated for minio minio/minio#20560 (comment)

So etiher we start skipping IT tests on s390x or we pin to latest available with s390x for a while and upgrade to latest tag for other architectures. (can be done in another PR)

@apupier apupier merged commit 3294ac0 into apache:main Oct 15, 2024
@apupier apupier deleted the fixMainBranch-minioLatestNotPushedFors390x branch October 15, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants