chore: avoid flakiness of DefaultSupervisingTest#16002
Merged
davsclaus merged 1 commit intoapache:mainfrom Oct 18, 2024
Merged
Conversation
the 2 exhausted failure collected were not always the last two. So adapting the assertion to check in the full list the right number of exhausted failure instead of the last 2 elements Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
oscerd
approved these changes
Oct 18, 2024
davsclaus
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the 2 exhausted failure collected were not always the last two. So adapting the assertion to check in the full list the right number of exhausted failure instead of the last 2 elements.
Based on what I understand from the codebase, the order is not important (but if it the case, we need to fix something in runtime code and not the test)
Description
Note that this test was failing very often on different architecture (so usually marked with a last failure of 1)
For instance:
https://ci-builds.apache.org/job/Camel/job/Camel%20Core%20(Build%20and%20test)/job/main/475/testReport/junit/org.apache.camel.impl.engine/DefaultSupervisingRouteControllerTest/BuildAndTest___Matrix___JDK_NAME____jdk_21_latest___PLATFORM____ubuntu_avx____Test___testSupervising_2/
https://ci-builds.apache.org/job/Camel/job/Camel%20Core%20(Build%20and%20test)/job/main/471/testReport/junit/org.apache.camel.impl.engine/DefaultSupervisingRouteControllerTest/BuildAndTest___Matrix___JDK_NAME____jdk_17_latest___PLATFORM____s390x____Test___testSupervising/
Note that the improved assertion message revela the issue:
Target
camel-3.x, whereas Camel 4 uses themainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.