Skip to content

feat(components): add camel-telemetry component#16949

Merged
squakez merged 1 commit intoapache:mainfrom
squakez:feat/tracing_2
Feb 12, 2025
Merged

feat(components): add camel-telemetry component#16949
squakez merged 1 commit intoapache:mainfrom
squakez:feat/tracing_2

Conversation

@squakez
Copy link
Contributor

@squakez squakez commented Jan 28, 2025

First implementation of the camel-telemetry abstract component as described in CAMEL-21670 - longer term goal will be to replace the actual camel-tracing with this one instead.

NOTE: this is a draft to collect early feedback. The final work is planned for release 4.11.0 version.

Scope of the work:

  • Based on camel-tracing
  • Abstract development as provided in the design document
  • Include "enableProcessors" feature as provided in camel-opentelemetry
  • Wide range of unit test to cover the main use cases
  • Inmemory implementation of a mock Tracer which is service to test the logic without needing a concrete implementation

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@squakez
Copy link
Contributor Author

squakez commented Jan 28, 2025

@davsclaus @oscerd FYI, as it's a new component can you verify all poms are okey? I think to recall something else from catalog side may be needed, please, advice.

@davsclaus
Copy link
Contributor

At first glance it looks correct - this is added to catalog as other and also added to the nav in the docs etc.

@oscerd
Copy link
Contributor

oscerd commented Jan 28, 2025

Seems good. Everything in order.

@squakez
Copy link
Contributor Author

squakez commented Jan 28, 2025

Okey, then, I'll wait for a review on the logic of the component. I will keep this on hold at least until 4.10 is released.

@squakez squakez marked this pull request as ready for review February 12, 2025 08:52
@squakez
Copy link
Contributor Author

squakez commented Feb 12, 2025

Blocked by netplex/json-smart-v2#240

First implementation of the abstract component as described in CAMEL-21670
@squakez squakez merged commit ef8aeee into apache:main Feb 12, 2025
4 checks passed
@squakez squakez deleted the feat/tracing_2 branch February 12, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants