Skip to content

camel-kubernetes: fixes and improvements#17115

Merged
jamesnetherton merged 7 commits intoapache:mainfrom
avano:camel-kubernetes-fixes
Feb 13, 2025
Merged

camel-kubernetes: fixes and improvements#17115
jamesnetherton merged 7 commits intoapache:mainfrom
avano:camel-kubernetes-fixes

Conversation

@avano
Copy link
Contributor

@avano avano commented Feb 11, 2025

Description

fixes

  • incorrect error message when jobspec was empty
  • incorrect constant used for doListResourceQuotasByLabels
  • incorrect constant used for doGetServiceAccount
  • CAMEL-21737 - fix k8s client usage in consumers

features

  • support namespace header in configmaps list and listByLabels
  • support namespace query parameter in configmaps consumer

docs

  • Fix incorrect endpoint in namespaces docs

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@avano avano force-pushed the camel-kubernetes-fixes branch 3 times, most recently from 5f8668a to 50dba7a Compare February 12, 2025 07:47
@avano avano marked this pull request as draft February 12, 2025 08:20
@avano
Copy link
Contributor Author

avano commented Feb 12, 2025

converting to draft - I just found out that multiple consumers in camel-kubernetes are using the kubernetes client incorrectly and are ignoring the query parameters - will fix

@avano avano force-pushed the camel-kubernetes-fixes branch from 50dba7a to 72e19bd Compare February 13, 2025 07:35
@avano avano marked this pull request as ready for review February 13, 2025 07:36
@avano
Copy link
Contributor Author

avano commented Feb 13, 2025

using mvn -Dkubernetes.test.auth="$KUBE_TOKEN" -Dkubernetes.test.host=$KUBE_HOST -Dkubernetes.test.host.k8s=true clean verify as mentioned in camel-kubernetes readme:

surefire: Tests run: 154, Failures: 0, Errors: 0, Skipped: 5
failsafe: Tests run: 43, Failures: 0, Errors: 0, Skipped: 0

@jamesnetherton
Copy link
Contributor

jamesnetherton commented Feb 13, 2025

/component-test kubernetes

Result ✅ The tests passed successfully

@github-actions
Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jamesnetherton jamesnetherton merged commit 91d9ff0 into apache:main Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants