feat(core): remove exchanges deprecated constants#19963
Conversation
They have been deprecated long ago and no internal code is making use of those constants any longer.
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
| defineMapping(Exchange.CONTENT_TYPE, Message.CONTENT_TYPE); | ||
| defineMapping(Exchange.HTTP_CHARACTER_ENCODING, Message.ENCODING); | ||
| defineMapping(Exchange.HTTP_QUERY, Message.QUERY_STRING); | ||
| defineMapping(Exchange.ACCEPT_CONTENT_TYPE, Message.ACCEPT_CONTENT_TYPE); |
There was a problem hiding this comment.
The ACCEPT_CONTENT_TYPE is never used internally. This method was a mapping, and in theory the user should have been already moved to CXF message accept content type instead.
| // in case of exception we are bridged then we want to perform | ||
| // redeliveries etc. | ||
| // so we need to turn of exhausted redelivery | ||
| oldExchange.removeProperties(Exchange.REDELIVERY_EXHAUSTED); |
There was a problem hiding this comment.
Never used, the test passes locally.
| public final class SoapConstants { | ||
|
|
||
| public static String SOAP_METHOD_NAME = "CamelSoapMethodName"; | ||
| public static String SOAP_ACTION = "CamelSoapAction"; |
There was a problem hiding this comment.
This is for internal use only in order to support the component. The user should changes nothing.
|
|
||
| public static final HttpString AUTHENTICATION = new HttpString("CamelAuthentication"); | ||
| public static final HttpString AUTHENTICATION_FAILURE_POLICY_ID = new HttpString("CamelAuthenticationFailurePolicyId"); | ||
| @Deprecated(since = "4.17.0") |
There was a problem hiding this comment.
We could have removed as it's not in use. However, let's follow the deprecation policy and mark it now for future removal.
|
|
||
| XMLReader xmlReader = null; | ||
| try { | ||
| // use the SAXPaserFactory which is set from exchange |
There was a problem hiding this comment.
Nobody should use this in Camel 4 since a while as it was deprecated in 3.x. We should be safe removing this piece of code. The original feature was introduced in https://issues.apache.org/jira/browse/CAMEL-7721
2 participants
They have been deprecated long ago and no internal code is making use of those constants any longer.
More details in the files changes.
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.