Skip to content

Conversation

@davsclaus
Copy link
Contributor

…is for all the other adoc files like done in camel-file

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

…is for all the other adoc files like done in camel-file
@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@rhaetor
Copy link
Contributor

rhaetor commented Nov 24, 2025

Just to be clear, what caused me to create the original PR was that the endpoint options should be inside the endpoint marker, not inside the component marker.

@davsclaus
Copy link
Contributor Author

Just to be clear, what caused me to create the original PR was that the endpoint options should be inside the endpoint marker, not inside the component marker.

Yeah well spotted as those doc files was misleading

…is for all the other adoc files like done in camel-file
…is for all the other adoc files like done in camel-file
@davsclaus
Copy link
Contributor Author

We should also fold the

// component headers: START
include::partial$component-endpoint-headers.adoc[]
// component headers: END

into the same so its just 1 placeholder all together

…is for all the other adoc files like done in camel-file
…is for all the other adoc files like done in camel-file
…is for all the other adoc files like done in camel-file
…is for all the other adoc files like done in camel-file
@davsclaus davsclaus marked this pull request as ready for review November 25, 2025 05:56
@davsclaus davsclaus merged commit c850e0c into main Nov 25, 2025
5 checks passed
@davsclaus davsclaus deleted the docclean branch November 25, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants