Skip to content

Conversation

@oscerd
Copy link
Contributor

@oscerd oscerd commented Dec 15, 2025

…WS S3

Description

This a proposal, to move some part of the common logic for AWS clients in a separated module, this should help us avoiding a lot of duplicated code and make the addition of more credentials provider easier. Please provide feedback. The implementation is for AWS S3. I'm planning to add the others if this work out for everyone.

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@oscerd oscerd requested a review from davsclaus December 15, 2025 10:47
@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@oscerd
Copy link
Contributor Author

oscerd commented Dec 15, 2025

Marked as draft

@oscerd
Copy link
Contributor Author

oscerd commented Dec 15, 2025

/component-tests aws

Result ✅ The tests passed successfully

@github-actions
Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@davsclaus
Copy link
Contributor

you may need to add this new common module as something to skip in the tooling/maven - I think we do this for camel-debezium-common

@oscerd oscerd force-pushed the aws-common-proposal branch from e458e87 to 513be48 Compare December 15, 2025 12:43
@oscerd
Copy link
Contributor Author

oscerd commented Dec 15, 2025

It should be ok now.

…on in a separated module - AWS S3

Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
@oscerd oscerd force-pushed the aws-common-proposal branch from 513be48 to f82f6a4 Compare December 15, 2025 12:49
@oscerd oscerd marked this pull request as ready for review December 15, 2025 12:50
@oscerd oscerd merged commit cfafc48 into main Dec 15, 2025
4 checks passed
@oscerd oscerd deleted the aws-common-proposal branch December 15, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants