camel-blueprint-schemagen-fix #2104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@sermojohn is this a similar fix that you did for camel-spring |
Contributor
Author
|
Yes. However, there are some new challenges due to the fact that schema-generation is provided in a maven profile. This did not work well with jdk9 profile, because the enable-schemagen profile would be disabled (when not explicitly enabling profiles). This was fixed as well. When enable-schemagen profile is disabled through the new system property disable-schemagen, the build fails because some plugins look for the camel-blueprint.xsd file. I believe this was existing issue, but is still not fixed by my commit. |
Contributor
|
Okay so you can build camel-blueprint on windows now on both java 8 and java 9 with this PR? |
Contributor
Author
|
Yes |
Contributor
|
Thanks for the PR it has been merged. Do you mind closing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to jaxb2-maven-plugin for camel-spring schemagen (similar to CAMEL-11942)
Also, due to the use of activeByDefault profile for schema generation, the build failed on jdk9 because the schema was never generated. So I applied a common pattern of using a property (named disable-schemagen) instead of activeByDefault, which can be used for disabling schema generation (probably intended for on-hpjdk and on-ibmjdk profiles). As a result, both jdk9 and jdk < 9 builds succeed.
However, there is still an issue when disabling schema generation, because the camel-blueprint.xsd is required by camel-eip-documentation-enricher-maven-plugin, so in practice schema generation should never be disabled based on the existing build script.