Skip to content

(chores): reduce cognitive complexity in camel-jms #21087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orpiske merged 4 commits into from
Jan 30, 2026
Merged

(chores): reduce cognitive complexity in camel-jms #21087

orpiske merged 4 commits into from
Jan 30, 2026
+173 −158

Conversation

@orpiske
Copy link
Contributor

@orpiske orpiske commented Jan 27, 2026

Summary

  • Extract helper methods in JmsBinding for message type filtering and date formatting
  • Simplify normalizeDestinationName in JmsMessageHelper by extracting normalizeWithPrefix helper
  • Refactor AsyncCallback.done in EndpointMessageListener with evaluateExchangeResult, handleReplyIfNeeded, handleExceptionIfNeeded helpers
  • Extract handleTimeout, handleSuccessfulReply, restoreOriginalCorrelationId methods from ReplyManagerSupport.processReply

Test plan

  • mvn -DskipTests install passes
  • Tests pass (existing flaky tests unrelated to changes)

@orpiske
(chores): reduce cognitive complexity in JmsBinding
e1bcd40 
Extract filterMessageByType and formatDateHeaderValue helper methods.
Use guard clauses to simplify getValidJMSHeaderValue.
@orpiske
(chores): reduce cognitive complexity in JmsMessageHelper
6fe1c9b 
Extract normalizeWithPrefix helper method to reduce duplication.
Use guard clauses instead of else-if chain.
@orpiske
(chores): reduce cognitive complexity in EndpointMessageListener
3bcff7c 
Extract evaluateExchangeResult, handleReplyIfNeeded, and
handleExceptionIfNeeded helper methods from the done callback.
Use guard clauses to flatten nesting.
@orpiske
(chores): reduce cognitive complexity in ReplyManagerSupport
d58a06d 
Extract handleTimeout, handleSuccessfulReply, and restoreOriginalCorrelationId
helper methods from processReply. Use guard clause for early return.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@orpiske
Copy link
Contributor Author

orpiske commented Jan 30, 2026

This one has good coverage, so let's merge.

@orpiske orpiske merged commit 7e7cbcc into apache:main Jan 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

camel-4 components components-jms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@orpiske