Skip to content

Conversation

@apupier
Copy link
Contributor

@apupier apupier commented Jan 27, 2026

Several tests were checking only that the result was not null and empty. Now checking some subparts of expected result and the file type.

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Several tests were checking only that the result was not null and empty.
Now checking some subparts of expected result and the file type.

Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@apupier apupier force-pushed the improveIntegrationTestsDocling branch from 0a501a3 to 0dc7f08 Compare January 27, 2026 15:29
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but, out of curiosity? why are you removing the public modifier?

@apupier
Copy link
Contributor Author

apupier commented Jan 27, 2026

why are you removing the public modifier?

Since JUnit 5, the public modifier is no more required and even recommended to be omited https://docs.junit.org/5.13.0-M2/user-guide/index.html#writing-tests-classes-and-methods

There is also a Sonar rule https://rules.sonarsource.com/java/quickfix/RSPEC-5786/

@apupier apupier merged commit 18e97b1 into apache:main Jan 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants