Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
there is some more work in jbang I think there are some java17 tests in kubernetes plugin (run and export) the export flag for --java-version description says 17 or 21 |
Contributor
Author
|
yes, this the beginning. there is the virtual threads side |
Contributor
|
https://github.com/apache/camel-spring-boot/blob/main/core/camel-spring-boot/pom.xml#L277 this should be removed in camel spring boot, and the java21 (test) folder need to be merged with the java one. I remember we had something similar in Camel too, but it seems like it was already removed |
- Jenkinsfile: remove jdk_17_latest from matrix axis and JDK_FILTER choices, remove JDK 21 excludes on ppc64le/s390x so the new baseline runs on all platforms, move coverage profile to the JDK 21 build, and run Sonar analysis on JDK 21 instead of JDK 17 - Jenkinsfile.deploy: default JDK changed to jdk_21_latest - Jenkinsfile.jbangtest: default JDK changed to jdk_21_latest Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
With JDK 21 as the minimum baseline, the multi-release JAR pattern used in camel-util and camel-support for virtual thread support is no longer needed. Merge the JDK 21 source variants (src/main/java21/) into the main source tree: - ThreadType: now checks camel.threads.virtual.enabled system property directly instead of always returning PLATFORM - CamelThreadFactory: now implements ThreadFactoryTypeAware with Thread.ofPlatform()/Thread.ofVirtual() builder support - DefaultThreadPoolFactory: now includes ThreadPoolFactoryType enum with VIRTUAL variant using Executors.newThreadPerTaskExecutor() Remove java-21-sources profile and Multi-Release JAR manifest entries from both camel-util and camel-support pom.xml files. Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
With JDK 21 as the minimum baseline, JDK 17 is no longer a valid choice for the camel-jbang export --java-version flag. - Remove 17 from @metadata enums in CamelJBangConstants - Update JBang script headers from JAVA 17+ to JAVA 21+ - Update ExportMainJibTest to test explicit Java 21 instead of 17 - Update MigrationTools to require Java 21+ for Camel 4.19+ - Regenerate metadata JSON and docs Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Contributor
Author
|
From this side this should be completed. |
davsclaus
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.