Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet
approved these changes
Mar 10, 2026
Contributor
gnodet
left a comment
There was a problem hiding this comment.
Minor observations:
- convertToJson() casting — The JsonObject converter casts exchange.getIn().getBody() directly. If the body is a primitive JSON value (string, number), this would throw ClassCastException. However, this is consistent with how other converters in the codebase work (Camel's type converter framework handles the routing).
- Shorthand aliases — The PR adds aliases like JsonObject, JsonArray, and Json (for Jsonable) in resolveClass(), but only for the single-arg overload. The ClassLoader-specific overloads don't get the aliases. This is fine for typical usage (convertBodyTo("JsonObject")).
- Missing test coverage — There's no test for the Json → Jsonable alias specifically, though the converter tests cover the underlying conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.