CAMEL-21917: Fix flaky JMS transacted and security tests#21917
Merged
gnodet merged 1 commit intoapache:mainfrom Mar 12, 2026
Merged
CAMEL-21917: Fix flaky JMS transacted and security tests#21917gnodet merged 1 commit intoapache:mainfrom
gnodet merged 1 commit intoapache:mainfrom
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Croway
approved these changes
Mar 10, 2026
cb96fba to
8ec5bd6
Compare
oscerd
approved these changes
Mar 10, 2026
72c89a3 to
cece145
Compare
88b8121 to
25bd6b2
Compare
25bd6b2 to
8204363
Compare
0978989 to
477e7e2
Compare
- Pre-create custom DLQ queues in Artemis broker config, since Artemis does not auto-create dead letter queues for custom DLQ addresses without autoCreateDeadLetterResources enabled - Use per-class DLQ names to avoid interference between concurrent tests - Set explicit maxDeliveryAttempts (1 or 3) per test for faster and deterministic redelivery behavior - Enforce test method ordering with @TestMethodOrder/@order to prevent message leakage via shared broker queues (RouteIdTransactedIT, JmsToJmsTransactedIT) - Increase Awaitility/timeout values for CI stability under load - Fix JmsToJmsTransactedSecurityIT to work on JDK 25 by using SASL_PLAINTEXT for Artemis security configuration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8154608 to
209c428
Compare
davsclaus
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix multiple flaky JMS transacted and security tests in
camel-jmsthat were failing intermittently on CI (both JDK 21 and JDK 25).Root Causes & Fixes
DLQ tests failing with null receive (
JmsTransactedDeadLetterChannelNotHandlerRollbackOnExceptionIT,JmsTransactedDeadLetterChannelHandlerRollbackOnExceptionIT,JmsTransactedOnExceptionRollbackOnExceptionIT,JmsToJmsTransactedIT)autoCreateDeadLetterResources. Fixed by pre-creating the DLQ queue in broker config viacfg.addQueueConfiguration(QueueConfiguration.of(dlqName).setRoutingType(RoutingType.ANYCAST))DLQ.<ClassName>) to prevent interference between concurrent testsmaxDeliveryAttempts(1 or 3) per test for faster, deterministic redeliveryMessage leakage between test methods (
RouteIdTransactedIT,JmsToJmsTransactedIT)@TestMethodOrder(MethodOrderer.OrderAnnotation.class)and@OrderannotationsTimeout flakiness under CI load
Awaitilitytimeouts and@Timeoutvalues in several tests that were too tight for CIJDK 25 compatibility (
JmsToJmsTransactedSecurityIT)Files Changed (22 files)
JmsTransactedDeadLetterChannelNotHandlerRollbackOnExceptionIT,JmsTransactedDeadLetterChannelHandlerRollbackOnExceptionIT,JmsTransactedOnExceptionRollbackOnExceptionITJmsToJmsTransactedIT,RouteIdTransactedITJmsToJmsTransactedSecurityITJmsProducerWithJMSHeaderTest,JmsRouteWithInOnlyAndMultipleAcksTest,JmsRouteWithInOnlyTest,AsyncConsumerInOutTwoTest,JmsAddAndRemoveRouteManagementIT, and othersAbstractArtemisEmbeddedService