Conversation
|
/component-test google |
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
✅ |
|
The build error is metnioning atmosphere, the version fo atmosphere was upgraded just after this branch diverge. Could you try to rebase on main branch please? |
|
Rebased |
|
Same error it seems |
|
Atmosphere 4.0.14 is jdk 21 only. It needs to be reverted for jdk 17 to be supported |
gnodet
left a comment
There was a problem hiding this comment.
Nice, well-structured component following Camel conventions.
A few observations:
-
Missing RESPONSE_OBJECT header: Other Google components (e.g., camel-google-secret-manager) set a header with the raw API response object, allowing advanced users to access additional metadata. Consider adding a
GoogleCloudTextToSpeechConstants.RESPONSE_OBJECTheader with theSynthesizeSpeechResponse. -
No producer unit tests: There are endpoint/component tests but no test that verifies the producer logic (request building, header mapping, response handling). Even a test with a mocked
TextToSpeechClientwould help catch regressions. -
The component structure, annotations, and documentation all look good.
…nd speech-to-text components Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
|
🧪 CI tested the following changed modules:
Full reactor (26 modules)
|
|
Locally for me it is working with 21,25 and 17 |
…nd speech-to-text components (apache#22036) Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
…nd speech-to-text components
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.