Skip to content

CAMEL-23198 - Camel-Google: Like AWS and IBM, create text-to-speech a…#22036

Merged
oscerd merged 1 commit intomainfrom
23198
Mar 18, 2026
Merged

CAMEL-23198 - Camel-Google: Like AWS and IBM, create text-to-speech a…#22036
oscerd merged 1 commit intomainfrom
23198

Conversation

@oscerd
Copy link
Contributor

@oscerd oscerd commented Mar 16, 2026

…nd speech-to-text components

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@apupier
Copy link
Contributor

apupier commented Mar 16, 2026

/component-test google

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions
Copy link
Contributor

/component-test google tests passed successfully.

@apupier
Copy link
Contributor

apupier commented Mar 16, 2026

The build error is metnioning atmosphere, the version fo atmosphere was upgraded just after this branch diverge. Could you try to rebase on main branch please?

@oscerd
Copy link
Contributor Author

oscerd commented Mar 16, 2026

Rebased

@oscerd
Copy link
Contributor Author

oscerd commented Mar 16, 2026

Same error it seems

@oscerd
Copy link
Contributor Author

oscerd commented Mar 16, 2026

Atmosphere 4.0.14 is jdk 21 only. It needs to be reverted for jdk 17 to be supported

Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, well-structured component following Camel conventions.

A few observations:

  1. Missing RESPONSE_OBJECT header: Other Google components (e.g., camel-google-secret-manager) set a header with the raw API response object, allowing advanced users to access additional metadata. Consider adding a GoogleCloudTextToSpeechConstants.RESPONSE_OBJECT header with the SynthesizeSpeechResponse.

  2. No producer unit tests: There are endpoint/component tests but no test that verifies the producer logic (request building, header mapping, response handling). Even a test with a mocked TextToSpeechClient would help catch regressions.

  3. The component structure, annotations, and documentation all look good.

…nd speech-to-text components

Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
@github-actions
Copy link
Contributor

🧪 CI tested the following changed modules:

  • bom/camel-bom
  • catalog/camel-allcomponents
  • catalog/camel-catalog
  • components/camel-google
  • components/camel-google/camel-google-speech-to-text
  • components/camel-google/camel-google-text-to-speech
  • core/camel-main
  • docs
  • dsl/camel-componentdsl
  • dsl/camel-endpointdsl
  • dsl/camel-kamelet-main
  • parent
  • tooling/maven/camel-package-maven-plugin
Full reactor (26 modules)
  • Camel :: All Components Sync point
  • Camel :: All Components Sync point [pom]
  • Camel :: BOM
  • Camel :: BOM [pom]
  • Camel :: Catalog :: Camel Catalog
  • Camel :: Catalog :: Camel Catalog [jar]
  • Camel :: Component DSL
  • Camel :: Component DSL [jar]
  • Camel :: Docs
  • Camel :: Docs [pom]
  • Camel :: Endpoint DSL
  • Camel :: Endpoint DSL [jar]
  • Camel :: Google :: Parent
  • Camel :: Google :: Parent [pom]
  • Camel :: Google :: Speech To Text
  • Camel :: Google :: Speech To Text [jar]
  • Camel :: Google :: Text To Speech
  • Camel :: Google :: Text To Speech [jar]
  • Camel :: Kamelet Main
  • Camel :: Kamelet Main [jar]
  • Camel :: Main
  • Camel :: Main [jar]
  • Camel :: Maven Plugins :: Camel Maven Package
  • Camel :: Maven Plugins :: Camel Maven Package [maven-plugin]
  • Camel :: Parent
  • Camel :: Parent [pom]

@oscerd
Copy link
Contributor Author

oscerd commented Mar 18, 2026

Locally for me it is working with 21,25 and 17

@oscerd oscerd merged commit 4691281 into main Mar 18, 2026
5 of 9 checks passed
vignesh-manel pushed a commit to vignesh-manel/camel that referenced this pull request Mar 18, 2026
…nd speech-to-text components (apache#22036)

Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants