chore(ci): Add fallback for properties not in dependencyManagement#22040
Merged
chore(ci): Add fallback for properties not in dependencyManagement#22040
Conversation
Some properties (e.g., mcp-java-sdk-version) are defined in the parent
POM properties but used directly in module pom.xml files via ${prop},
not through the parent's dependencyManagement section.
The Toolbox tree-find approach only works for managed artifacts. For
properties without a managed artifact, fall back to grepping module
pom.xml files for ${property} references (the original approach, which
works correctly for this case).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
vignesh-manel
pushed a commit
to vignesh-manel/camel
that referenced
this pull request
Mar 18, 2026
…pache#22040) Some properties (e.g., mcp-java-sdk-version) are defined in the parent POM properties but used directly in module pom.xml files via ${prop}, not through the parent's dependencyManagement section. The Toolbox tree-find approach only works for managed artifacts. For properties without a managed artifact, fall back to grepping module pom.xml files for ${property} references (the original approach, which works correctly for this case). Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #22022. Some properties (e.g.,
mcp-java-sdk-version) are defined in the parent POM but used directly in modulepom.xmlfiles via${prop}, not through the parent's<dependencyManagement>section.The Toolbox
tree-findapproach only works for managed artifacts. For properties without a managed artifact, this adds a fallback that greps modulepom.xmlfiles for${property}references.Discovered from CI logs on PR #22018 where
mcp-java-sdk-versionwas correctly detected as changed but no modules were found because the property is referenced directly incamel-openai/pom.xmlrather than through dependency management.