Skip to content

CAMEL-23112 - add back JDk 17 on Jenkins#22041

Merged
apupier merged 1 commit intoapache:mainfrom
apupier:23112-jenkinsJava17
Mar 18, 2026
Merged

CAMEL-23112 - add back JDk 17 on Jenkins#22041
apupier merged 1 commit intoapache:mainfrom
apupier:23112-jenkinsJava17

Conversation

@apupier
Copy link
Copy Markdown
Contributor

@apupier apupier commented Mar 16, 2026

Kept JDK 21 as the "principal" target branch for coverage and Sonar check

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@apupier apupier force-pushed the 23112-jenkinsJava17 branch from daeba4f to 2c86d9b Compare March 16, 2026 14:53
Kept JDK 21 as the "principal" target branch for coverage and Sonar
check

Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@apupier apupier force-pushed the 23112-jenkinsJava17 branch from 2c86d9b to b116c89 Compare March 16, 2026 14:53
@github-actions github-actions bot added the ci label Mar 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Copy link
Copy Markdown
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JDK 17 support changes look straightforward.

One question about the deploy defaults change: switching from deploy to no-deploy as the default in Jenkinsfile.deploy could affect other pipelines or jobs that rely on the current default behavior. Is this intentional, or should it be a separate change?

The rest (adding JDK 17 to the build matrix, test matrix) looks fine.

@apupier
Copy link
Copy Markdown
Contributor Author

apupier commented Mar 17, 2026

One question about the deploy defaults change: switching from deploy to no-deploy as the default in Jenkinsfile.deploy could affect other pipelines or jobs that rely on the current default behavior. Is this intentional, or should it be a separate change?

there is no such change in this PR as far as i can see. Can you provide more details?

@apupier apupier requested a review from gnodet March 17, 2026 09:34
@apupier
Copy link
Copy Markdown
Contributor Author

apupier commented Mar 18, 2026

One question about the deploy defaults change: switching from deploy to no-deploy as the default in Jenkinsfile.deploy could affect other pipelines or jobs that rely on the current default behavior. Is this intentional, or should it be a separate change?

there is no such change in this PR as far as i can see. Can you provide more details?

merging as it is causing JBang tests failing as they are using the snapshots version deployed on the Apache Snapshots repository which are for now compiled with JDK 21.

Please follow-up in a specific issue to discuss what you reported with more details

@apupier apupier merged commit a46bb3c into apache:main Mar 18, 2026
2 checks passed
@apupier apupier deleted the 23112-jenkinsJava17 branch March 18, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants