Conversation
- Increase Awaitility timeouts from 3-6s to 15s across all SMB tests to prevent race conditions in CI environments - Add initialDelay=3000 to SmbComponentConnectionIT consumer routes to prevent the consumer from polling before producer writes complete - Fix NPE in copyFileContentFromContainer when file not yet available by throwing AssertionError instead of returning null, which Awaitility properly catches and retries Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
oscerd
approved these changes
Mar 18, 2026
Contributor
|
🧪 CI tested the following changed modules:
Full reactor (72 modules)
|
Several tests use assertNull(copyFileContentFromContainer(...)) to verify files have been deleted or were never created. The AssertionError throw prevented these assertions from ever succeeding. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
apupier
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initialDelay=3000toSmbComponentConnectionITconsumer routes to prevent the consumer from polling before producer writes complete (fixesexpected: <Good Bye> but was: <>)SmbServerTestSupport.copyFileContentFromContainerwhen the file hasn't been moved yet — now throwsAssertionErrorinstead of returningnull, which Awaitility properly catches and retriesTest plan