Skip to content

CAMEL-22527: Fix flaky JettyFailoverRoundRobinTest #22094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnodet merged 2 commits into from
Mar 19, 2026
Merged

CAMEL-22527: Fix flaky JettyFailoverRoundRobinTest #22094

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a9d84e
CAMEL-22527: Fix flaky JettyFailoverRoundRobinTest
gnodet Mar 19, 2026
403d692
CAMEL-22527: Remove redundant @AfterEach port cleanup
gnodet Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions ...mel-jetty/src/test/java/org/apache/camel/component/jetty/JettyFailoverRoundRobinTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,23 +22,20 @@
import org.apache.camel.test.AvailablePortFinder;
import org.apache.camel.test.junit6.CamelTestSupport;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;

import static org.junit.jupiter.api.Assertions.assertEquals;

public class JettyFailoverRoundRobinTest extends CamelTestSupport {
private static int port1 = AvailablePortFinder.getNextAvailable();
private static int port2 = AvailablePortFinder.getNextAvailable();
private static int port3 = AvailablePortFinder.getNextAvailable();
private static int port4 = AvailablePortFinder.getNextAvailable();

private String bad = "jetty:http://localhost:" + port1 + "/bad";
private String bad2 = "jetty:http://localhost:" + port2 + "/bad2";
private String good = "jetty:http://localhost:" + port3 + "/good";
private String good2 = "jetty:http://localhost:" + port4 + "/good2";
private String hbad = "http://localhost:" + port1 + "/bad";
private String hbad2 = "http://localhost:" + port2 + "/bad2";
private String hgood = "http://localhost:" + port3 + "/good";
private String hgood2 = "http://localhost:" + port4 + "/good2";
@RegisterExtension
AvailablePortFinder.Port port1 = AvailablePortFinder.find();
@RegisterExtension
AvailablePortFinder.Port port2 = AvailablePortFinder.find();
@RegisterExtension
AvailablePortFinder.Port port3 = AvailablePortFinder.find();
@RegisterExtension
AvailablePortFinder.Port port4 = AvailablePortFinder.find();

@Test
void testJettyFailoverRoundRobin() throws Exception {
Expand Down Expand Up @@ -78,28 +75,31 @@ public void configure() {
// -1 is to indicate that failover LB should newer exhaust and keep trying
.loadBalance().failover(-1, false, true)
// this is the four endpoints we will load balance with failover
.to(hbad, hbad2, hgood, hgood2);
.to("http://localhost:" + port1.getPort() + "/bad",
"http://localhost:" + port2.getPort() + "/bad2",
"http://localhost:" + port3.getPort() + "/good",
"http://localhost:" + port4.getPort() + "/good2");
// END SNIPPET: e1

from(bad)
from("jetty:http://localhost:" + port1.getPort() + "/bad")
.to("mock:bad")
.process(exchange -> {
exchange.getIn().setHeader(Exchange.HTTP_RESPONSE_CODE, 500);
exchange.getIn().setBody("Something bad happened");
});

from(bad2)
from("jetty:http://localhost:" + port2.getPort() + "/bad2")
.to("mock:bad2")
.process(exchange -> {
exchange.getIn().setHeader(Exchange.HTTP_RESPONSE_CODE, 404);
exchange.getIn().setBody("Not found");
});

from(good)
from("jetty:http://localhost:" + port3.getPort() + "/good")
.to("mock:good")
.process(exchange -> exchange.getIn().setBody("Good"));

from(good2)
from("jetty:http://localhost:" + port4.getPort() + "/good2")
.to("mock:good2")
.process(exchange -> exchange.getIn().setBody("Also good"));
}
Expand Down
Loading