Skip to content

[build] Clarify CI test comment when dependent modules are not tested#22098

Merged
gnodet merged 1 commit intomainfrom
ci/improve-test-comment-clarity
Mar 19, 2026
Merged

[build] Clarify CI test comment when dependent modules are not tested#22098
gnodet merged 1 commit intomainfrom
ci/improve-test-comment-clarity

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented Mar 19, 2026

Summary

  • When CI can't test all dependent modules (> 50 threshold), the PR comment previously showed "Full reactor (N modules)" — making it look like all N modules were tested when only the changed modules actually were
  • Now the comment clearly indicates:
    • An info note explaining dependents were skipped and how to force them (test-dependents label)
    • The reactor summary is labeled "Build reactor — dependencies compiled but only changed modules were tested"
  • When dependents ARE tested (< threshold or test-dependents label), the label remains "All tested modules"

Example of improved comment when dependents are skipped:

🧪 CI tested the following changed modules:

  • components/camel-as2/camel-as2-api

ℹ️ Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the test-dependents label to force testing all dependents.

Test plan

  • Reviewed logic flow for all test paths (test-dependents label, threshold exceeded, normal)
  • Verified testedDependents variable is properly initialized and set in all branches

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

When the number of dependent modules exceeds the threshold (50), CI
only tests the changed modules but the PR comment listed all reactor
modules under "Full reactor" — making it unclear what was actually
tested.

Now the comment:
- Adds an info note explaining dependents were skipped and how to
  force testing them (test-dependents label)
- Changes the reactor summary label to "Build reactor — dependencies
  compiled but only changed modules were tested"
- Keeps the "All tested modules" label when dependents are tested

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@gnodet gnodet merged commit 44a855c into main Mar 19, 2026
2 checks passed
@gnodet gnodet deleted the ci/improve-test-comment-clarity branch March 20, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants