Merged
Conversation
- Disable flaky LogCaptureTest in camel-netty and camel-netty-http - Remove unnecessary (Object) cast on constant(null) calls - Disable flaky HazelcastQueueConsumerPollTest on CI - Remove deprecated StorageBackend.COUCHSTORE from CouchbaseIntegrationTestBase Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
…ption wrapping Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nTestBase, and .thenReturn(null) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The consumer's background thread starts polling queue.poll() during context startup, but the Mockito stub was only set up in the test method — after the consumer was already polling. This is a Mockito thread-safety race (concurrent stubbing and invocation). Fix: set up queue.poll() mock in trainHazelcastInstance() (before context start) using an Answer backed by a LinkedBlockingQueue. Tests put items into the backing queue, which is fully thread-safe. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
oscerd
approved these changes
Mar 20, 2026
gansheer
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miscellaneous test fixes:
HazelcastQueueConsumerPollTestby replacing fragile mock stubbing with a thread-safeLinkedBlockingQueuebacking, sopoll()behaves realistically regardless of consumer timingNettyHttpSSLHandshakeErrorTestto acceptSSLHandshakeExceptionwrapped inDecoderException, which Netty may do depending on timing