[XChange] Add initial support for account management#2216
Merged
davsclaus merged 1 commit intoapache:masterfrom Feb 13, 2018
Merged
[XChange] Add initial support for account management#2216davsclaus merged 1 commit intoapache:masterfrom
davsclaus merged 1 commit intoapache:masterfrom
Conversation
Resolves CAMEL-12170
davsclaus
requested changes
Feb 10, 2018
| return exchange; | ||
| } | ||
|
|
||
| private synchronized XChange createXChange(XChangeConfiguration configuration) { |
Contributor
There was a problem hiding this comment.
Its better to do this in doStart so you dont need synchronized code blocks
Contributor
Author
There was a problem hiding this comment.
I'd like to create the XChange once so it can be shared among all endpoints. For this I'd need some piece of information that names the exchange. This is currently encoded in the URI and (if IIUC) becomes available when the endpoint is created.
If I do this initialization in Endpoint.doStart(), I'd still need to synchronize unless it is guaranteed that endpoints are not started in parallel (also in the future).
If I do this initialization in Component.doStart(), I'd not know how to get at the piece of information that names the exchange.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves CAMEL-12170