Skip to content

CAMEL-23226: Fix exit codes for validation errors in camel-jbang commands#22162

Merged
gnodet merged 1 commit intomainfrom
CAMEL-23226-fix-exit-codes
Mar 23, 2026
Merged

CAMEL-23226: Fix exit codes for validation errors in camel-jbang commands#22162
gnodet merged 1 commit intomainfrom
CAMEL-23226-fix-exit-codes

Conversation

@gnodet
Copy link
Contributor

@gnodet gnodet commented Mar 21, 2026

JIRA: CAMEL-23226

Summary

Many camel-jbang commands return exit code 0 (success) when validation fails, which breaks scripting and CI/CD usage where non-zero exit codes are expected on errors.

  • Fix return 0 to return 1 in 17 commands where validation errors (missing PID, invalid arguments) incorrectly returned success
  • Affected commands: CamelBeanDump, CamelBrowseAction, CamelHistoryAction, CamelLoadAction, CamelRouteDumpAction, CamelRouteStructureAction, CamelSendAction, CamelSourceAction, CamelSourceTop, CamelStartupRecorderAction, CamelStubAction, CamelThreadDump, EvalExpressionCommand, RouteControllerAction, TransformMessageAction, PluginDelete, Jolokia

Test plan

  • Verify commands return exit code 1 when required PID is not specified
  • Verify commands still return 0 on success
  • Verify scripting patterns like camel get beans --pid=invalid || echo "failed" work correctly

…ands

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the dsl label Mar 21, 2026
@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions
Copy link
Contributor

🧪 CI tested the following changed modules:

  • dsl/camel-jbang/camel-jbang-core
All tested modules (26 modules)
  • Camel :: Coverage
  • Camel :: Coverage [pom]
  • Camel :: JBang :: Core
  • Camel :: JBang :: Core [jar]
  • Camel :: JBang :: Integration tests
  • Camel :: JBang :: Integration tests [jar]
  • Camel :: JBang :: MCP
  • Camel :: JBang :: MCP [jar]
  • Camel :: JBang :: Main
  • Camel :: JBang :: Main [jar]
  • Camel :: JBang :: Plugin :: Edit
  • Camel :: JBang :: Plugin :: Edit [jar]
  • Camel :: JBang :: Plugin :: Generate
  • Camel :: JBang :: Plugin :: Generate [jar]
  • Camel :: JBang :: Plugin :: Kubernetes
  • Camel :: JBang :: Plugin :: Kubernetes [jar]
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: Route Parser [jar]
  • Camel :: JBang :: Plugin :: Testing
  • Camel :: JBang :: Plugin :: Testing [jar]
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: JBang :: Plugin :: Validate [jar]
  • Camel :: Launcher
  • Camel :: Launcher [jar]
  • Camel :: Launcher :: Container
  • Camel :: Launcher :: Container [pom]

@gnodet gnodet merged commit e5a8f5a into main Mar 23, 2026
5 checks passed
@gnodet gnodet deleted the CAMEL-23226-fix-exit-codes branch March 23, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants