Skip to content

chore(components): harmonize mgt port usage#22186

Merged
squakez merged 1 commit intoapache:mainfrom
squakez:chore/obs_svc_default_port
Mar 23, 2026
Merged

chore(components): harmonize mgt port usage#22186
squakez merged 1 commit intoapache:mainfrom
squakez:chore/obs_svc_default_port

Conversation

@squakez
Copy link
Copy Markdown
Contributor

@squakez squakez commented Mar 23, 2026

As it already happens for CSB and Q runtimes

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

As it already happens for CSB and Q runtimes
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Copy link
Copy Markdown
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code on behalf of Guillaume Nodet

A few observations on this change:

Behavioral change

This is not just harmonization — it's a behavioral change for existing users. Before this PR, if someone uses camel-observability-services with camel-main (without the k8s export path), the management endpoints bind to port 8080 (the default in HttpManagementServerConfigurationProperties). After this PR, they bind to 9876. This could silently break existing deployments that have health checks, monitoring, or load balancers pointing at 8080.

Migration guide

Since this changes the default port, it should be documented in the upgrade guide (docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_19.adoc) so users are aware of the change.

Scattered defaults

The "9876" default is now defined in multiple places:

  • KubernetesExport.java:523 — hardcoded "9876" as fallback
  • observability-services.properties — this PR
  • observability-services.adoc — docs already claim 9876

Meanwhile, HttpManagementServerConfigurationProperties still defaults to 8080. It might be cleaner to change the default at the source (HttpManagementServerConfigurationProperties.port = 9876) or use a shared constant, rather than overriding it per-location. That way all consumers automatically get the right default.

Missing JIRA

Should there be a JIRA issue tracking this change?

@squakez
Copy link
Copy Markdown
Contributor Author

squakez commented Mar 23, 2026

No, this is bringing back to the default as expected to 9876 as already documented in version 4.12. We have introduced some regression along the way. Minor change, no Jira required.

@squakez squakez merged commit 54ca275 into apache:main Mar 23, 2026
5 checks passed
@squakez squakez deleted the chore/obs_svc_default_port branch March 23, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants