CAMEL-23274: Disable SonarCloud temporarily and fix script injection#22477
Merged
gnodet merged 1 commit intoapache:mainfrom Apr 8, 2026
Merged
CAMEL-23274: Disable SonarCloud temporarily and fix script injection#22477gnodet merged 1 commit intoapache:mainfrom
gnodet merged 1 commit intoapache:mainfrom
Conversation
Temporarily disable sonar-build and sonar-scan workflows until the SonarCloud quality gate is adjusted (INFRA-27808). The quality gate requires ≥80% coverage on new code, but only core modules produce coverage currently, causing failures on all PRs and main builds. Also fix a BLOCKER vulnerability (githubactions:S7630) in sonar-build.yml: user-controlled GitHub Actions expressions (github.event.pull_request.head.ref) were used directly in run blocks, enabling script injection. Moved to env variables. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAMEL-23274
Summary
sonar-buildandsonar-scanworkflows until the SonarCloud quality gate is adjusted (INFRA-27808)githubactions:S7630insonar-build.yml: user-controlled expressions (github.event.pull_request.head.ref) used directly inrunblocks enable script injection — moved toenvvariablesWhy disable?
The quality gate requires ≥80% coverage, but only core modules produce coverage data. This causes failures on all PRs touching components and on main branch builds. A request to adjust the gate has been filed as INFRA-27808.
To re-enable: remove the
false &&from theifconditions in both workflow files.Test plan
sonar-build.ymljob condition evaluates tofalse, workflow is skippedsonar-scan.ymljob condition evaluates tofalse, workflow is skippedenvvariables instead of direct expression interpolation