Skip to content

CAMEL-23313: HeaderFilter Strategies - add lowerCase where it's not present - JMS, SJMS, CoAP, Google PubSub#22569

Merged
oscerd merged 1 commit intoapache:mainfrom
oscerd:ci-issue-CAMEL-23313
Apr 13, 2026
Merged

CAMEL-23313: HeaderFilter Strategies - add lowerCase where it's not present - JMS, SJMS, CoAP, Google PubSub#22569
oscerd merged 1 commit intoapache:mainfrom
oscerd:ci-issue-CAMEL-23313

Conversation

@oscerd
Copy link
Copy Markdown
Contributor

@oscerd oscerd commented Apr 13, 2026

Summary

Adds setLowerCase(true) to five HeaderFilterStrategy implementations for consistency with the other components that already call it (HttpHeaderFilterStrategy, Sqs2HeaderFilterStrategy, MailHeaderFilterStrategy, KafkaHeaderFilterStrategy, etc.):

  • camel-jms: JmsHeaderFilterStrategy, ClassicJmsHeaderFilterStrategy
  • camel-sjms: SjmsHeaderFilterStrategy
  • camel-coap: CoAPHeaderFilterStrategy
  • camel-google-pubsub: GooglePubsubHeaderFilterStrategy

This aligns the startsWith filter behaviour across components, matching the pattern established in the CAMEL-21885 series of changes.

Tracked as CAMEL-23313.

Test plan

  • mvn -DskipTests install in each affected module (camel-jms, camel-sjms, camel-coap, camel-google-pubsub) - all green
  • mvn -Dtest=PubsubHeaderFilterTest test in camel-google-pubsub - 13/13 pass
  • mvn -Dtest=CoAPHeaderFilterStrategyTest test in camel-coap - 2/2 pass
  • CI will exercise the JMS/SJMS integration tests (require Artemis broker)

Claude Code on behalf of Andrea Cosentino

…resent - JMS, SJMS, CoAP, Google PubSub

Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
@oscerd oscerd requested review from davsclaus and orpiske April 13, 2026 07:41
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@davsclaus
Copy link
Copy Markdown
Contributor

We could also make DefaultFilterStrategy having lowercase = true as default it seems

@oscerd oscerd merged commit 3d2efee into apache:main Apr 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants