Skip to content

chore: fix FQCN in AggregateProcessorTest#23035

Closed
gnodet wants to merge 1 commit intoapache:mainfrom
gnodet:fix-fqcn-aggregate-processor-test
Closed

chore: fix FQCN in AggregateProcessorTest#23035
gnodet wants to merge 1 commit intoapache:mainfrom
gnodet:fix-fqcn-aggregate-processor-test

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented May 7, 2026

Summary

  • Fix fully-qualified java.util.concurrent.TimeUnit.SECONDS usage in AggregateProcessorTest — add proper import and use simple class name instead.
  • This was introduced in commit 9e5c829 (CAMEL-22539) and causes CI failure in the "Fail if there are uncommitted changes" step because the OpenRewrite FQCN-shortening plugin rewrites it during the build.

Test plan

  • mvn compile test-compile -pl core/camel-core passes
  • CI "uncommitted changes" check passes

…ges check

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the core label May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@gnodet
Copy link
Copy Markdown
Contributor Author

gnodet commented May 7, 2026

The CAMEL-22539 PR (#23024) was created and CI-tested before the OpenRewrite FQCN enforcement (#22935) was merged. Its CI passed because the rewrite rule wasn't active yet. When it was subsequently merged into main — which now includes the OpenRewrite plugin — the build rewrites the inline java.util.concurrent.TimeUnit.SECONDS to use a proper import, producing an uncommitted diff that fails the "Fail if there are uncommitted changes" CI check.

Claude Code on behalf of Guillaume Nodet

@gnodet
Copy link
Copy Markdown
Contributor Author

gnodet commented May 7, 2026

Duplicated by #23036

@gnodet gnodet closed this May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🧪 CI tested the following changed modules:

  • core/camel-core

⚠️ Some tests are disabled on GitHub Actions (@DisabledIfSystemProperty(named = "ci.env.name")) and require manual verification:

  • core/camel-core: 2 test(s) disabled on GitHub Actions

⚙️ View full build and test results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants