ci: test Scalpel shadow — junit-jupiter-version test dependency [DO NOT MERGE]#23063
Closed
gnodet wants to merge 4 commits intoapache:mainfrom
Closed
ci: test Scalpel shadow — junit-jupiter-version test dependency [DO NOT MERGE]#23063gnodet wants to merge 4 commits intoapache:mainfrom
gnodet wants to merge 4 commits intoapache:mainfrom
Conversation
Upgrade Scalpel from extension3:0.1.0 to extension:0.3.0 and run it in shadow mode — observing what skip-tests mode would do without affecting actual test execution. This allows validating Scalpel's decisions across many PRs before switching to Scalpel-driven test execution. Changes: - Upgrade Scalpel to 0.3.0 with source-set-aware propagation and skipTestsForDownstreamModules support - Pre-fetch base branch in CI workflow (avoids JGit issues in shallow clones) - Remove persist-credentials: false (needed for git fetch operations) - Add shadow comparison section to PR comments showing what Scalpel skip-tests mode would have tested vs the current approach - Update CI-ARCHITECTURE.md with shadow comparison documentation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Scalpel 0.3.0 upgrade is already on main. This PR focuses on the shadow comparison feature, not the version bump. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Switch the grep-based incremental build script from fetching diffs via the GitHub REST API to using local git merge-base + diff. Both the grep script and Scalpel now share the same --deepen=200 fetch step, removing the GitHub API dependency for diff fetching. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet
force-pushed
the
test-scalpel-shadow-b
branch
from
624de76 to
7439d61
Compare
Contributor
Author
|
Closing — version didn't exist. Recreating with real version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR for Scalpel shadow comparison validation
DO NOT MERGE — validates PR #22524.
Scenario B: Test-scoped managed dependency (junit-jupiter-version)
Adds a comment near
junit-jupiter-versioninparent/pom.xml. No module directly references${junit-jupiter-version}— it's consumed via<dependencyManagement>.Expected:
This demonstrates grep's blind spot for managed dependencies and Scalpel's scope awareness.