Skip to content

chore: upgrade okhttp3 in camel-salesforce-component#23073

Merged
davsclaus merged 3 commits into
apache:mainfrom
tmielke:okhttp-upgrade-salesforce
May 7, 2026
Merged

chore: upgrade okhttp3 in camel-salesforce-component#23073
davsclaus merged 3 commits into
apache:mainfrom
tmielke:okhttp-upgrade-salesforce

Conversation

@tmielke
Copy link
Copy Markdown

@tmielke tmielke commented May 7, 2026

Upgrading dependency com.squareup.okhttp3:okhttp to latest 5.3.2 version (already defined in parent/pom.xml)
as currently used version 3.14.9 is 6 years old!
This updates camel-salesforce/camel-salesforce-component to use com.squareup.okhttp3:okhttp-jvm:5.3.2 and
com.squareup.okhttp3:mockwebserver3:5.2.
An update to unit test RawPayloadTest was needed for the tests to pass.

With this upgrade, no other Camel component or module depends on property ${squareup-okhttp-version} as defined in parent/pom.xml. So removing this property entirely, relying only on ${squareup-okhttp5-version}.
All of Camel rebuilt successfully with the property removed from parent/pom.xml.

Made with help from AI tools.

Torsten Mielke added 3 commits May 7, 2026 13:51
Upgrading dependency com.squareup.okhttp3:okhttp to latest 5.3.2 version
(already defined in parent/pom.xml) as currently used version
3.14.9 is 6 years old!

This updates camel-jetty and camel-olingo2 to use com.squareup.okhttp3:okhttp-jvm:5.3.2.
Component camel-huaweicloud-obs references okhttp3 as compile time dependency but it is
not used there at all. So okhttp3 got removed as a dependency there.
All unit tests of these components pass, with the exception of JettySessionSupportTest
in camel-jetty. However this test fails for me on main branch as well and does not
use okhttp classes in any way.

The only component left to use com.squareup.okhttp3:okhttp:3.14.9 is camel-salesforce.
A quick attempt to upgrade to version 5.3.2 here as well failed and breaks many unit
tests. So this component will require a separate investigation.

Made with help from AI tools.
Upgrading dependency com.squareup.okhttp3:okhttp to latest 5.3.2 version (already defined in parent/pom.xml)
as currently used version 3.14.9 is 6 years old!
This updates camel-salesforce/camel-salesforce-component to use com.squareup.okhttp3:okhttp-jvm:5.3.2 and
com.squareup.okhttp3:mockwebserver3:5.2.
An update to unit test RawPayloadTest was needed for the tests to pass.

With this upgrade, no other Camel component or module depends on property ${squareup-okhttp-version}
as defined in parent/pom.xml. So removing this property entirely, relying only on ${squareup-okhttp5-version}.
All of Camel rebuilt successfully with the property removed from parent/pom.xml.

Made with help from AI tools.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🧪 CI tested the following changed modules:

  • components/camel-huawei/camel-huaweicloud-obs
  • components/camel-jetty
  • components/camel-olingo2/camel-olingo2-component
  • components/camel-salesforce/camel-salesforce-component
  • parent

ℹ️ Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the test-dependents label to force testing all dependents.

POM dependency changes: targeted tests included

Changed properties: squareup-okhttp-version

Modules affected by dependency changes (1)
  • :camel-salesforce

⚠️ Some tests are disabled on GitHub Actions (@DisabledIfSystemProperty(named = "ci.env.name")) and require manual verification:

  • components/camel-jetty: 1 test(s) disabled on GitHub Actions
Build reactor — dependencies compiled but only changed modules were tested (5 modules)
  • Camel :: Huawei Cloud :: OBS
  • Camel :: Jetty
  • Camel :: Olingo2 (Deprecated) :: Component
  • Camel :: Parent
  • Camel :: Salesforce

⚙️ View full build and test results

@davsclaus davsclaus merged commit 6b83090 into apache:main May 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants