Skip to content

Improve mdc.adoc#23124

Merged
davsclaus merged 1 commit into
apache:mainfrom
abedurftig:improve-mdc-adoc
May 12, 2026
Merged

Improve mdc.adoc#23124
davsclaus merged 1 commit into
apache:mainfrom
abedurftig:improve-mdc-adoc

Conversation

@abedurftig
Copy link
Copy Markdown
Contributor

I was trying to get this running in my Spring Boot application. I noticed that the documentation could be improved.

  • update the usage; auto-configuration only works of the camel-mdc-starter is added
  • otherwise service must be created and added
  • camel.mdc properties names didn't match implementation

@davsclaus
Copy link
Copy Markdown
Contributor

For Spring Boot you should always use the -starter - that is for all of the camel components.

@davsclaus davsclaus requested a review from squakez May 11, 2026 14:13
Copy link
Copy Markdown
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't generally explain in the components how to deal when adopting springboot or main (or quarkus). It is kind of implicity that, in order to use a component, then you have to add the component dependency or starter (or quarkus extension).

As for the property names, yes, they had to be fixed, thanks. However, I'd keep the example explanation in order to show the user how to use wildcards when they want to include any pattern for a property or header.

IMO, the only change we should add are the property names changes.

@abedurftig
Copy link
Copy Markdown
Contributor Author

Thanks for your feedback. I was not able to get it working right away. The fact that there might be a starter occurred too late, that's why I updated the docs. But if this is a convention, then maybe redundant.

Are these conventions documented somewhere?

Should I revert everything but the property names?

@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions
Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • components/camel-mdc
All tested modules (8 modules)
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Launcher :: Container
  • Camel :: MDC
  • Camel :: YAML DSL :: Validator
  • Camel :: YAML DSL :: Validator Maven Plugin

⚙️ View full build and test results

@davsclaus
Copy link
Copy Markdown
Contributor

Thanks for your feedback. I was not able to get it working right away. The fact that there might be a starter occurred too late, that's why I updated the docs. But if this is a convention, then maybe redundant.

Are these conventions documented somewhere?

in the camel spring boot docs
https://camel.apache.org/camel-spring-boot/4.18.x/index.html

Should I revert everything but the property names?

yes thanks as suggested by @squakez

@abedurftig
Copy link
Copy Markdown
Contributor Author

abedurftig commented May 11, 2026

Alright. There were some changes on main on the exact lines of code, so I rebased and cleaned up. So, the changes are really only the property names.

in the camel spring boot docs

Thanks for sharing.

@davsclaus davsclaus merged commit cb3f2b0 into apache:main May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants