CAMEL-23477: camel-jbang-mcp - Stop re-embedding pomContent in migrateProject prompt#23140
Merged
Conversation
…eProject prompt Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
davsclaus
approved these changes
May 12, 2026
Contributor
|
🧪 CI tested the following changed modules:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops re-embedding the full
pomContentargument inside themigrate_projectpromptinstructions. Previously,
PromptDefinitions.migrateProjectinlined the entire pom.xmlinside a multi-paragraph workflow block, so the prompt size grew linearly with pom size —
duplicating content the client typically already has in conversation context. Verbose
"Step 1 … Step 6" descriptions are also compressed into a tight numbered list.
JIRA: CAMEL-23477
Changes
pomContentis nowrequired = false(backward compatible — old clients still send it).acknowledgement of whether a pom was supplied or should be read from conversation context.
list, preserving every tool call and decision branch (
camel_migration_analyze,camel_version_list,camel_migration_wildfly_karaf,camel_migration_compatibility,camel_migration_recipes,camel_migration_guide_search).Test plan
PromptDefinitionsTest:migrateProjectContainsPomContent(which asserted the pom was inlined).migrateProjectDoesNotInlinePomContent— supplies a 1000×<dependency/>pom andasserts the resulting prompt size matches the size produced by a small pom, and that the
large pom text is not present in the output.
migrateProjectAcknowledgesSuppliedPom,migrateProjectFallsBackToContextWhenPomOmitted,and
migrateProjectBlankPomFallsBackToContext.mvn verifyindsl/camel-jbang/camel-jbang-mcp— passes.mvn clean install -DskipTests) — passes; no regen artifacts.Acceptance
Verified by
migrateProjectDoesNotInlinePomContent.Claude Code on behalf of Andrea Cosentino