CAMEL-23404: Improve SFTP security documentation and add strictHostKeyChecking policy enforcement#23143
Merged
Merged
Conversation
oscerd
approved these changes
May 12, 2026
85f720f to
fc5c2c3
Compare
Croway
approved these changes
May 12, 2026
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
…yChecking policy enforcement - Added security="insecure:ssl" annotation to strictHostKeyChecking parameter - Enhanced parameter description to warn about MITM vulnerability when disabled - Added comprehensive Security Best Practices section to sftp-component.adoc - Documented recommended secure configuration patterns with examples - Generated metadata now includes security policy enforcement for strictHostKeyChecking Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
fc5c2c3 to
1d43a90
Compare
…pComponent - Added 6 component-level properties for global host key verification configuration: * strictHostKeyChecking (with security="insecure:ssl" annotation) * knownHostsFile * knownHostsUri * knownHosts (byte array) * useUserKnownHostsFile * autoCreateKnownHostsFile - Component settings are applied as defaults during endpoint creation - Endpoint URI parameters can override component-level settings - Updated documentation with global configuration examples (Java and Spring Boot) - Generated component metadata and configurer updated automatically Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
Author
|
Added host key security options on component level so it can be configured globally and much easier |
…aseSftpConfiguration changes The full reactor build regenerated: - mina-sftp component metadata (inherits strictHostKeyChecking security annotation) - sensitive-keys catalog (adds knownhosts* fields) - SensitiveUtils patterns (adds knownhosts* to sensitive key patterns) These changes were missed in the module-scoped builds and are now included. Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
a9cc86d to
c5b21f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves documentation and adds security policy enforcement for the
strictHostKeyCheckingparameter in the SFTP component, as requested in CAMEL-23404.Changes
1. Security Annotation (
BaseSftpConfiguration.java)security = "insecure:ssl"to thestrictHostKeyCheckingparameter annotationno2. Documentation (
sftp-component.adoc)strictHostKeyChecking=no)knownHostsFilewithstrictHostKeyChecking=yesknownHostsUrifor classpath-loaded known hosts~/.ssh/known_hosts(default behavior)3. Generated Metadata (
sftp.json)security: "insecure:ssl"attributeTest Plan
strictHostKeyChecking=yes(requires SFTP server)camel.security.insecureSslPolicy=fail)Documentation
Documentation has been enhanced with:
🤖 Generated with Claude Code on behalf of Claus Ibsen