-
Notifications
You must be signed in to change notification settings - Fork 5.1k
CAMEL-23483: add manual acknowledgment support for camel-nats JetStream consumer #23144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Croway
merged 1 commit into
apache:main
from
Croway:feature/CAMEL-23483-nats-manual-ack
May 12, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
95 changes: 49 additions & 46 deletions
95
catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/nats.json
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 49 additions & 46 deletions
95
...nts/camel-nats/src/generated/resources/META-INF/org/apache/camel/component/nats/nats.json
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
...onents/camel-nats/src/main/java/org/apache/camel/component/nats/DefaultNatsManualAck.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.camel.component.nats; | ||
|
|
||
| import java.time.Duration; | ||
|
|
||
| import io.nats.client.Message; | ||
|
|
||
| class DefaultNatsManualAck implements NatsManualAck { | ||
|
|
||
| private final Message message; | ||
|
|
||
| DefaultNatsManualAck(Message message) { | ||
| this.message = message; | ||
| } | ||
|
|
||
| @Override | ||
| public void ack() { | ||
| message.ack(); | ||
| } | ||
|
|
||
| @Override | ||
| public void nak() { | ||
| message.nak(); | ||
| } | ||
|
|
||
| @Override | ||
| public void nakWithDelay(Duration delay) { | ||
| message.nakWithDelay(delay); | ||
| } | ||
|
|
||
| @Override | ||
| public void term() { | ||
| message.term(); | ||
| } | ||
|
|
||
| @Override | ||
| public void inProgress() { | ||
| message.inProgress(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
components/camel-nats/src/main/java/org/apache/camel/component/nats/NatsManualAck.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.camel.component.nats; | ||
|
|
||
| import java.time.Duration; | ||
|
|
||
| /** | ||
| * Allows manual acknowledgment of JetStream messages when using the NATS consumer with {@code manualAck=true}. | ||
| * | ||
| * @see NatsConstants#NATS_MANUAL_ACK | ||
| */ | ||
| public interface NatsManualAck { | ||
|
|
||
| /** | ||
| * Acknowledge the message. | ||
| */ | ||
| void ack(); | ||
|
|
||
| /** | ||
| * Negative acknowledge the message. The message will be redelivered immediately. | ||
| */ | ||
| void nak(); | ||
|
|
||
| /** | ||
| * Negative acknowledge the message with a delay before redelivery. | ||
| */ | ||
| void nakWithDelay(Duration delay); | ||
|
|
||
| /** | ||
| * Terminate delivery of this message. The server will stop redelivering it. | ||
| */ | ||
| void term(); | ||
|
|
||
| /** | ||
| * Signal that processing is still in progress. Resets the {@code ackWait} timer to prevent the server from | ||
| * redelivering while long-running processing is ongoing. | ||
| */ | ||
| void inProgress(); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: prefer the constant over the string literal — matches how camel-kafka docs reference
KafkaConstants.MANUAL_COMMITand keeps the doc example aligned withNatsConstants.NATS_MANUAL_ACK.