Fix copy-paste error in camel-milo MiloClientConfiguration (found by OpenScanHub SAST)#23174
Merged
Merged
Conversation
MiloClientConfiguration used getMaxPendingPublishRequests() instead of getMaxResponseMessageSize() when configuring the OPC UA client's max response message size, applying the wrong value to the size limit.
oscerd
approved these changes
May 13, 2026
davsclaus
approved these changes
May 13, 2026
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (8 modules)
|
davsclaus
pushed a commit
that referenced
this pull request
May 13, 2026
MiloClientConfiguration used getMaxPendingPublishRequests() instead of getMaxResponseMessageSize() when configuring the OPC UA client's max response message size, applying the wrong value to the size limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix a copy-paste error in
MiloClientConfigurationwheregetMaxPendingPublishRequests()was called instead ofgetMaxResponseMessageSize()when configuring the OPC UA client's max response message size.Why
The OPC UA client's
maxResponseMessageSizeis set to the value ofmaxPendingPublishRequestsinstead ofmaxResponseMessageSize. This applies the wrong value to the message size limit — for example, ifmaxPendingPublishRequestsis 10, the max response size would be set to 10 bytes instead of the intended limit.Fix
Change
configuration.getMaxPendingPublishRequests()toconfiguration.getMaxResponseMessageSize()on line 464.Found via static analysis (Coverity
COPY_PASTE_ERRORchecker).