Skip to content

Fix copy-paste error in camel-milo MiloClientConfiguration (found by OpenScanHub SAST)#23174

Merged
davsclaus merged 1 commit into
apache:mainfrom
tedwon:fix/milo-copy-paste-error
May 13, 2026
Merged

Fix copy-paste error in camel-milo MiloClientConfiguration (found by OpenScanHub SAST)#23174
davsclaus merged 1 commit into
apache:mainfrom
tedwon:fix/milo-copy-paste-error

Conversation

@tedwon
Copy link
Copy Markdown
Contributor

@tedwon tedwon commented May 13, 2026

What

Fix a copy-paste error in MiloClientConfiguration where getMaxPendingPublishRequests() was called instead of getMaxResponseMessageSize() when configuring the OPC UA client's max response message size.

Why

The OPC UA client's maxResponseMessageSize is set to the value of maxPendingPublishRequests instead of maxResponseMessageSize. This applies the wrong value to the message size limit — for example, if maxPendingPublishRequests is 10, the max response size would be set to 10 bytes instead of the intended limit.

Fix

Change configuration.getMaxPendingPublishRequests() to configuration.getMaxResponseMessageSize() on line 464.

Found via static analysis (Coverity COPY_PASTE_ERROR checker).

MiloClientConfiguration used getMaxPendingPublishRequests() instead of
getMaxResponseMessageSize() when configuring the OPC UA client's max
response message size, applying the wrong value to the size limit.
@tedwon tedwon changed the title Fix copy-paste error in camel-milo MiloClientConfiguration Fix copy-paste error in camel-milo MiloClientConfiguration (found by OpenScanHub SAST) May 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions
Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • components/camel-milo
All tested modules (8 modules)
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Launcher :: Container
  • Camel :: Milo
  • Camel :: YAML DSL :: Validator
  • Camel :: YAML DSL :: Validator Maven Plugin

⚙️ View full build and test results

@davsclaus davsclaus merged commit a63155f into apache:main May 13, 2026
6 checks passed
davsclaus pushed a commit that referenced this pull request May 13, 2026
MiloClientConfiguration used getMaxPendingPublishRequests() instead of
getMaxResponseMessageSize() when configuring the OPC UA client's max
response message size, applying the wrong value to the size limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants