Fix 11 flaky tests in camel-core caused by timing issues#23190
Closed
gnodet wants to merge 3 commits into
Closed
Conversation
- FileSedaShutdownCompleteAllTasksTest: increase file poll delay to prevent duplicate exchanges from re-reading files before .camel/ move - ShutdownCompleteCurrentTaskOnlyTest: same file poll delay fix - MulticastParallelStreamingTimeoutTest: increase multicast timeout and mock wait time to handle thread pool starvation under CI load - MulticastParallelStreamingTest: use syncDelayed() instead of asyncDelayed() for deterministic delay ordering - MulticastParallelTimeoutStreamCachingTest: increase mock result wait time for IOException propagation under CI load Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
|
- MarkerFileExclusiveReadLockStrategyTest: increase file poll delay to prevent duplicate exchanges from re-reading files - MarkerFileExclusiveReadLockStrategyUnlockTest: same file poll delay fix - MarkerFileExclusiveReadLockStrategyRecursiveCleanupTest: same fix across all 5 test methods - FileConsumeFilesAndDeleteTest: same file poll delay fix - SedaBlockWhenFullTest: increase mock result wait time from 390ms to 1300ms to handle CI load delays - AggregateCompleteAllOnStopTest: increase completionTimeout from 100ms to 5000ms to prevent premature timeout-based completion between messages - RecipientListParallelStreamingTest: use syncDelayed() for deterministic delay ordering under thread pool pressure Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…3178 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 11 intermittently failing tests in
camel-corethat pass on rerun (rerunFailingTestsCount=2), confirming they are timing-dependent.File consumer
delay=10re-read fixes (6 tests)File consumer with
delay=10(10ms poll interval) re-reads files before they are moved to.camel/, creating duplicate exchanges. Increased todelay=2000for a single poll per test lifetime.Thread pool / timing fixes (4 tests)
asyncDelayed()uses scheduled executor subject to thread pool pressure. Switched tosyncDelayed()(Thread.sleep) for deterministic ordering.asyncDelayed()issue. AddedsyncDelayed().setResultWaitTime(15000).Aggregation timeout fix (1 test)
completionTimeout(100ms)fires between messages under CI load, prematurely completing aggregations. Increased to 5000ms.Test plan