CAMEL-23509: camel-lucene - align Exchange header constant values with Camel naming convention#23208
Merged
Merged
Conversation
…h Camel naming convention Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
davsclaus
approved these changes
May 14, 2026
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (10 modules)
|
oscerd
added a commit
that referenced
this pull request
May 14, 2026
…ader constant values with Camel naming convention Cherry-pick of #23208 onto camel-4.18.x for the 4.18.3 release line. Rename the values of the Exchange header constants exposed by LuceneConstants to follow the standard CamelLucene* convention: HEADER_QUERY: QUERY -> CamelLuceneQuery; HEADER_RETURN_LUCENE_DOCS: RETURN_LUCENE_DOCS -> CamelLuceneReturnLuceneDocs. Field names are unchanged so routes referencing the constants symbolically continue to work. Routes using literal string values must be updated. The camel-4x-upgrade-guide-4_21.adoc hunk from the source PR was dropped (file does not exist on camel-4.18.x). The matching 4.18 upgrade guide entry is added on main via doc-sync PR #23222. Closes #23220
oscerd
added a commit
that referenced
this pull request
May 14, 2026
…h Camel naming convention Backport of #23208 onto camel-4.14.x for the 4.14.8 release line. Renames the values of LuceneConstants.HEADER_QUERY and LuceneConstants.HEADER_RETURN_LUCENE_DOCS to follow the standard CamelLucene* naming convention. The constant field names are unchanged, so routes referencing the constants continue to work as-is. The cascading rename of the auto-generated Endpoint DSL accessors (qUERY() -> luceneQuery(), returnLuceneDocs() -> luceneReturnLuceneDocs()) is included. The matching 4.14.8 upgrade-guide entry was added to main via #23234.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the values of the Exchange header constants exposed by
LuceneConstantswith the standard CamelCamelLucene*naming convention.LuceneConstants.HEADER_QUERY:QUERY->CamelLuceneQueryLuceneConstants.HEADER_RETURN_LUCENE_DOCS:RETURN_LUCENE_DOCS->CamelLuceneReturnLuceneDocsThe field names (
HEADER_QUERY,HEADER_RETURN_LUCENE_DOCS) are unchanged, so routes that reference the constants continue to work without modification. Routes that set or read these headers using the raw string values must be updated.As a consequence of the value rename, the auto-generated Endpoint DSL header accessors on
LuceneHeaderNameBuilderare also renamed:qUERY()->luceneQuery()returnLuceneDocs()->luceneReturnLuceneDocs()An entry has been added to the 4.21 upgrade guide.
Changes
components/camel-lucene/.../LuceneConstants.java— header value renamecomponents/camel-lucene/src/main/docs/lucene-component.adoc— text reference updatelucene.json(component metadata + catalog mirror) andLuceneEndpointBuilderFactory.javadocs/user-manual/.../camel-4x-upgrade-guide-4_21.adoc— upgrade-guide entryTest plan
mvn verifyincomponents/camel-lucene(6 tests pass)mvn clean install -DskipTestsfrom repo root succeeds, all regen artifacts committedJIRA: https://issues.apache.org/jira/browse/CAMEL-23509
Claude Code on behalf of Andrea Cosentino