TUI: add p/P keys to start/stop/suspend/resume routes#23264
Merged
Conversation
On the Routes tab, p toggles start/stop and P toggles suspend/resume for the selected route. The footer shows context-sensitive hints based on the current route state (p=stop/P=suspend when started, p=start/P=resume when suspended, p=start when stopped). On the Overview tab, p toggles start/stop all routes for the selected integration using stopAllRoutes/startAllRoutes. The footer hint updates dynamically (p=stop when routes are running, p=start when all stopped). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (2 modules)
|
Three bottlenecks were causing the log tab to lag 30+ seconds behind when DEBUG-level logging produced a high volume of lines: 1. readLogFile re-read the last 1 MB from disk on every 100 ms refresh, re-split the full string and re-ran fixControlChars on all 5000 lines. Replaced with readNewLogLines which tracks logFilePos and reads only the bytes appended since the last call, using a logLineBuffer to handle partial lines at the read boundary. 2. applyLogFilters re-ran the log regex on all 5000 entries every refresh. Now only newly read raw lines are parsed and appended to the persistent mutableFilteredEntries list, published atomically via the volatile field. 3. renderLog rebuilt all 5000 Line objects via ansiToLine on every render frame, then handed all 5000 lines to Paragraph which iterated them on every frame to apply scroll. Now a cachedLogLines list is rebuilt only when filteredLogEntries changes or logHScroll changes; Paragraph is given only the visible window (~30 lines) so it no longer iterates the full entry list per frame. Also added l key on the Log tab to open a log-level selector popup (ERROR/WARN/INFO/DEBUG/TRACE) and shows the current root log level in the Log tab block title. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ptoggles start/stop andPtoggles suspend/resume for the currently selected route. The footer shows context-sensitive hints based on route state:p=stop,P=suspendp=start,P=resumep=startptoggles start/stop all routes for the selected integration (stopAllRoutes/startAllRoutes). The footer hint updates dynamically:p=stopwhen routes are running,p=startwhen all stopped.{"action":"route","id":"<id>","command":"start|stop|suspend|resume"}), withid=*for the all-routes Overview action.Test plan
p— route stops; footer switches top=startpagain — route starts; footer switches back top=stopPon a started route — route suspends; footer showsP=resumePagain — route resumesp— all routes stop; footer showsp=startpagain — all routes start; footer showsp=stopClaude Code on behalf of Claus Ibsen
🤖 Generated with Claude Code