CAMEL-23532: camel-vertx-websocket / camel-atmosphere-websocket / camel-iggy - use dedicated HeaderFilterStrategy aligned with sibling components#23285
Merged
Conversation
…el-iggy - use dedicated HeaderFilterStrategy aligned with sibling components Apply a HeaderFilterStrategy on the inbound header mapping of the vertx-websocket, atmosphere-websocket and iggy consumers, following the pattern already used by camel-coap (CAMEL-23222), camel-cometd (CAMEL-23507) and camel-nats (CAMEL-23515). - camel-vertx-websocket: new VertxWebsocketHeaderFilterStrategy, exposed via a headerFilterStrategy endpoint option, applied in VertxWebsocketConsumer.populateExchangeHeaders() before mapping query and path parameters. - camel-iggy: new IggyHeaderFilterStrategy, exposed via a headerFilterStrategy endpoint option, applied in IggyFetchRecords before copying message user-headers. - camel-atmosphere-websocket: apply the existing (inherited) HttpHeaderFilterStrategy in WebsocketConsumer before mapping query parameters; no new option required. Includes unit tests for the new strategies and an upgrade-guide note. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Croway
approved these changes
May 18, 2026
davsclaus
approved these changes
May 18, 2026
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (13 modules)
|
apupier
approved these changes
May 18, 2026
This was referenced May 19, 2026
oscerd
added a commit
that referenced
this pull request
May 19, 2026
…el-iggy - use dedicated HeaderFilterStrategy aligned with sibling components (#23313) Apply a HeaderFilterStrategy on the inbound header mapping of the vertx-websocket, atmosphere-websocket and iggy consumers, aligning them with the pattern already used by camel-coap (CAMEL-23222), camel-cometd (CAMEL-23507) and camel-nats (CAMEL-23515). vertx-websocket and iggy gain a new VertxWebsocketHeaderFilterStrategy / IggyHeaderFilterStrategy plus a headerFilterStrategy endpoint option; atmosphere-websocket reuses the HeaderFilterStrategy it already inherits from the HTTP/servlet stack. Includes unit tests and an upgrade-guide note. Closes #23285 (cherry picked from commit 1e77623) Signed-off-by: Andrea Cosentino <ancosen@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 20, 2026
oscerd
added a commit
that referenced
this pull request
May 20, 2026
…el-iggy - use dedicated HeaderFilterStrategy aligned with sibling components (#23352) Apply a HeaderFilterStrategy on the inbound header mapping of the vertx-websocket, atmosphere-websocket and iggy consumers, aligning them with the pattern already used by camel-coap (CAMEL-23222), camel-cometd (CAMEL-23507) and camel-nats (CAMEL-23515). vertx-websocket and iggy gain a new VertxWebsocketHeaderFilterStrategy / IggyHeaderFilterStrategy plus a headerFilterStrategy endpoint option; atmosphere-websocket reuses the HeaderFilterStrategy it already inherits from the HTTP/servlet stack. Includes unit tests and an upgrade-guide note. Closes #23285 (cherry picked from commit 1e77623) Signed-off-by: Andrea Cosentino <ancosen@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAMEL-23532
Aligns
camel-vertx-websocket,camel-atmosphere-websocketandcamel-iggywith theHeaderFilterStrategypattern already adopted across the component catalog (CAMEL-23222camel-coap, CAMEL-23507camel-cometd, CAMEL-23515camel-nats). Their inbound consumers previously mapped externally supplied key/value data (WebSocket query/path parameters; Iggy message user-headers) into the Camel message header map without aHeaderFilterStrategy.Changes
VertxWebsocketHeaderFilterStrategy(filtersCamel/camelheaders case-insensitively, both directions), exposed via a newheaderFilterStrategyendpoint option; applied inVertxWebsocketConsumer.populateExchangeHeaders()before mapping query and path parameters.IggyHeaderFilterStrategy, exposed via a newheaderFilterStrategyendpoint option; applied inIggyFetchRecordsbefore copying message user-headers.HttpHeaderFilterStrategyinWebsocketConsumerbefore mapping query parameters (no new option needed; the component already extends the HTTP/servlet stack).Tests
VertxWebsocketHeaderFilterStrategyTestandIggyHeaderFilterStrategyTest, mirroringNatsHeaderFilterStrategyTest.Docs
camel-4x-upgrade-guide-4_21.adoccovering the behaviour change, the new endpoint option, and the opt-out (supply a customheaderFilterStrategy).Generated artifacts
Fix Version/s on the issue: 4.21.0, 4.18.3, 4.14.8 (
camel-iggyis main + 4.18.x only — it does not exist on the 4.14.x line). Backports handled separately.Claude Code on behalf of Andrea Cosentino