Skip to content

Improve test assertion in ValidatorRouteTest#23292

Merged
apupier merged 1 commit into
apache:mainfrom
apupier:improveTestAssertions
May 18, 2026
Merged

Improve test assertion in ValidatorRouteTest#23292
apupier merged 1 commit into
apache:mainfrom
apupier:improveTestAssertions

Conversation

@apupier
Copy link
Copy Markdown
Contributor

@apupier apupier commented May 18, 2026

use AssertJ to have more details in case of test failures

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@apupier
Copy link
Copy Markdown
Contributor Author

apupier commented May 18, 2026

requires #23289 to pass but at least it shows the better error message

use AssertJ to have more details in case of test failures

Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@apupier apupier force-pushed the improveTestAssertions branch from 7978543 to d32f327 Compare May 18, 2026 13:22
@apupier apupier marked this pull request as ready for review May 18, 2026 14:24
@github-actions
Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • components/camel-json-validator

POM dependency changes: targeted tests included

Modules affected by dependency changes (1)
  • :camel-json-validator
All tested modules (9 modules)
  • Camel :: AI :: LangChain4j :: Agent
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: JSON validator
  • Camel :: Launcher :: Container
  • Camel :: YAML DSL :: Validator
  • Camel :: YAML DSL :: Validator Maven Plugin

⚙️ View full build and test results

@apupier apupier merged commit a56c641 into apache:main May 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants