[backport camel-4.18.x] CAMEL-23547: camel-core - Properties component should eager start custom functions resolver#23303
Merged
Conversation
…tom functions resolver. Same for jbang that has a custom resolver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of d1afebe onto camel-4.18.x
Cherry-pick of commit d1afebe onto
camel-4.18.x.Original commit: d1afebe - CAMEL-23547: camel-core - Properties component should eager start custom functions resolver. Same for jbang that has a custom resolver.
Target branch:
camel-4.18.xChanges
DefaultPropertiesFunctionResolver: addeddoBuild()lifecycle method that callsServiceHelper.buildService()on the registered functions, so they are properly built before use.KameletMain: theDependencyDownloaderPropertiesFunctionResolveris now eagerly started (viaresolver.start()) before being set on thePropertiesComponent, ensuring the custom functions resolver is fully initialised before properties resolution begins. Applied to both the normal and export code paths.Conflict resolution notes
The backport required minor adaptation: the 3-argument constructor added on
maindoes not exist oncamel-4.18.x, so the existing 2-argument constructor is used instead. The function registration in the constructor (which was moved todoBuild()onmain) is left as-is on 4.18.x to minimise the delta.Claude Code on behalf of Claus Ibsen