chore: improve PomSanitizer detection and robustness#23332
Merged
Conversation
- Handle CDATA-wrapped values (previously bypassed detection entirely)
- Recognize Camel property placeholders ({{...}}) in addition to Maven ${...}
- Detect URL-embedded credentials (://user:password@host) in any element
- Add connection-string/connectionstring/connection_string keywords
- Merge detection and masking into a single regex pass
- Replace Collectors.joining with String.join
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
oscerd
approved these changes
May 19, 2026
davsclaus
approved these changes
May 19, 2026
Contributor
|
🧪 CI tested the following changed modules:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve
PomSanitizerincamel-jbang-mcpto close detection gaps and simplify internals:<![CDATA[...]]>were previously invisible to detection — now inspected and masked{{vault:...}}and{{...}}placeholders are preserved alongside Maven${...}://user:password@hostin any element (catches JDBC URLs, HTTP basic auth in non-sensitive-named elements like<db.url>)connection-string,connectionstring,connection_stringString.joinreplacesCollectors.joining, removed unused import12 new test cases covering all additions.
Test plan
mvn test -Dtest=PomSanitizerTest— all 30 tests passClaude Code on behalf of Guillaume Nodet