Skip to content

CAMEL-23565: CI skip Scalpel analysis for root pom.xml changes#23371

Merged
davsclaus merged 1 commit into
mainfrom
ci-skip-root-pom-scalpel
May 21, 2026
Merged

CAMEL-23565: CI skip Scalpel analysis for root pom.xml changes#23371
davsclaus merged 1 commit into
mainfrom
ci-skip-root-pom-scalpel

Conversation

@davsclaus
Copy link
Copy Markdown
Contributor

Summary

  • Skip Scalpel POM analysis when only the root pom.xml changes (not parent/pom.xml or module-level pom.xml files)
  • The root pom.xml contains build-infrastructure config (license plugin, checkstyle, etc.) that doesn't affect module compilation or test behavior
  • Without this filter, Scalpel reports every module as affected because they all inherit from the root POM, causing CI to test the entire project unnecessarily (as seen in PR camel-tui: Add --record option and demo tape recordings #23364)

Changes

  • .github/actions/incremental-build/incremental-build.sh: Changed Scalpel trigger condition to only fire when a subdirectory pom.xml changes — extracts file paths from the diff with sed and checks for paths containing at least one directory level before pom.xml
  • .github/CI-ARCHITECTURE.md: Document the root pom.xml exclusion behavior

Test plan

  • Verified grep logic handles all edge cases:
    • Root pom.xml only → Scalpel skipped
    • parent/pom.xml → Scalpel runs
    • Module pom.xml (e.g. components/camel-kafka/pom.xml) → Scalpel runs
    • Root + module pom.xml → Scalpel runs
    • No pom.xml changes → Scalpel skipped
  • CI run on this PR should only test CI-related files (not every module)

Claude Code on behalf of Claus Ibsen

The root pom.xml contains build-infrastructure config (license plugin,
checkstyle, etc.) that does not affect module compilation or test
behavior. When Scalpel analyzes root pom.xml changes, it reports every
module as affected since they all inherit from it, causing CI to test
the entire project unnecessarily.

Only invoke Scalpel when a subdirectory pom.xml changes (parent/pom.xml,
module pom.xml).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions github-actions Bot added the docs label May 20, 2026
@davsclaus davsclaus marked this pull request as ready for review May 20, 2026 12:01
@davsclaus davsclaus merged commit bf41db9 into main May 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants