Skip to content

chore: fail with clear error when script EIP has empty expression body #23385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davsclaus merged 1 commit into from
May 20, 2026
Merged

chore: fail with clear error when script EIP has empty expression body #23385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/camel-core-reifier/src/main/java/org/apache/camel/reifier/ScriptReifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
import org.apache.camel.Route;
import org.apache.camel.model.ProcessorDefinition;
import org.apache.camel.model.ScriptDefinition;
import org.apache.camel.model.language.ExpressionDefinition;
import org.apache.camel.processor.ScriptProcessor;
import org.apache.camel.util.ObjectHelper;

public class ScriptReifier extends ExpressionReifier<ScriptDefinition> {

Expand All @@ -31,7 +33,11 @@ public ScriptReifier(Route route, ProcessorDefinition<?> definition) {

@Override
public Processor createProcessor() throws Exception {
Expression expr = createExpression(definition.getExpression());
ExpressionDefinition exp = definition.getExpression();
if (exp == null || ObjectHelper.isEmpty(exp.getExpression())) {
throw new IllegalArgumentException("Script has no script code configured in " + definition);
}
Expression expr = createExpression(exp);
ScriptProcessor answer = new ScriptProcessor(expr);
answer.setDisabled(isDisabled(camelContext, definition));
return answer;
Expand Down