chore: fix bundled example not loading application.properties#23387
Merged
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
💡 Manual integration tests recommended:
All tested modules (6 modules)
|
When running a bundled example via camel run --example, the example's application.properties was extracted to a temp directory but profileProperties was loaded from the current working directory. This meant camel.jbang.dependencies and other properties from the example were never picked up by the runtime. Set exportBaseDir to the temp directory so run() uses it as baseDir, making loadProfileProperties find the correct application.properties. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
…e guide Add note about the MavenDownloaderImpl.preferLocal default changing from false to true in the 4.21 upgrade guide, as discussed in PR #23333. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
e1a6d8d to
431630c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
camel run --example groovy, the example'sapplication.propertieswas extracted to a temp directory butprofilePropertieswas loaded from the current working directory (.), socamel.jbang.dependenciesand other properties were never picked up by the runtime.exportBaseDir = tempDirinrunBundledExample()sorun()uses the temp directory asbaseDir, makingloadProfilePropertiesfind the correctapplication.properties.Test plan
camel run --example groovy --verboseand verifycommons-validator:commons-validator:1.10.1is resolved and the example runs without errorsmvn clean install -DskipTests)Claude Code on behalf of Claus Ibsen