Fix trace action handler to forward dump parameter to DevConsole#23419
Merged
Conversation
The doActionTraceTask() handler only checked for the "enabled" parameter and ignored "dump". When a caller requested a trace dump via the action file IPC, only status metadata was returned instead of the actual traced messages. Forward the dump parameter so TraceDevConsole calls dumpAllTracedMessages() and returns the trace array. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (7 modules)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doActionTraceTask()inLocalCliConnectorto forward thedumpparameter toTraceDevConsoleThe
TraceDevConsolealready supports thedumpparameter — the periodictraceTask()uses it correctly viaMap.of("dump", "true"). The action handler simply never wired it through.Test plan
mvn install -B -pl dsl/camel-cli-connector -DskipTestsbuilds clean