Skip to content

Fix trace action handler to forward dump parameter to DevConsole#23419

Merged
gnodet merged 1 commit into
apache:mainfrom
gnodet:fix/trace-dump-missing-messages
May 21, 2026
Merged

Fix trace action handler to forward dump parameter to DevConsole#23419
gnodet merged 1 commit into
apache:mainfrom
gnodet:fix/trace-dump-missing-messages

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented May 21, 2026

Summary

  • Fix doActionTraceTask() in LocalCliConnector to forward the dump parameter to TraceDevConsole
  • Without this, requesting a trace dump via action file IPC only returned status metadata (enabled, counter, queueSize) instead of the actual traced messages

The TraceDevConsole already supports the dump parameter — the periodic traceTask() uses it correctly via Map.of("dump", "true"). The action handler simply never wired it through.

Test plan

  • mvn install -B -pl dsl/camel-cli-connector -DskipTests builds clean
  • Manual: enable tracing, send messages, call trace dump via action file — verify traced messages are returned

The doActionTraceTask() handler only checked for the "enabled"
parameter and ignored "dump". When a caller requested a trace dump
via the action file IPC, only status metadata was returned instead
of the actual traced messages. Forward the dump parameter so
TraceDevConsole calls dumpAllTracedMessages() and returns the
trace array.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gnodet gnodet requested a review from davsclaus May 21, 2026 11:09
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions github-actions Bot added the dsl label May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • dsl/camel-cli-connector
All tested modules (7 modules)
  • Camel :: DSL :: CLI Connector
  • Camel :: DSL :: CLI Debug
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Launcher :: Container

⚙️ View full build and test results

@gnodet gnodet merged commit 385ce72 into apache:main May 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant