CAMEL-23583: camel-google-{functions,secret-manager,vision,text-to-speech,speech-to-text} - align Exchange header constant names with Camel naming convention#23467
Merged
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (14 modules)
|
gnodet
approved these changes
May 22, 2026
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Clean, well-structured PR that finishes the Camel-prefix alignment for the remaining 5 Google Cloud components. Reviewed the full diff — all 12 header renames are consistent with the convention used across the rest of the catalog.
What I verified:
- All 5 constants classes (
GoogleCloudFunctionsConstants,GoogleSecretManagerConstants,GoogleCloudVisionConstants,GoogleCloudTextToSpeechConstants,GoogleCloudSpeechToTextConstants) are correctly updated with theCamelprefix. - The already-compliant constants (
SECRET_ID,VERSION_ID,REPLICATION) inGoogleSecretManagerConstantsare correctly left untouched. - All other Google components (
bigquery,calendar,drive,firestore,mail,pubsub,sheets,storage,vertexai) already use theCamelprefix — this PR closes the gap for the 5 that were non-compliant. - Generated artifacts are consistent: catalog JSON (x5), component JSON (x5), endpoint DSL (x5) all reflect the new values.
- The upgrade guide entry is thorough — includes the full mapping table, notes on symbolic vs literal usage, and documents the DSL accessor behavior.
- No hardcoded old string values found in non-constants production code.
- Component doc pages reference the constants symbolically, so no changes needed there.
- CI is green across all JDK versions.
Minor note (not blocking): the PR title references CAMEL-23583 while the body says "Tracker: CAMEL-23577" — might be worth aligning if those are different JIRA tickets.
LGTM — approving.
Claude Code on behalf of Guillaume Nodet
…eech,speech-to-text} - align Exchange header constant names with Camel naming convention Renames the Exchange header string values in the Google Cloud component constants from their GoogleCloud<Service> / GoogleSecretManager prefixes (which are outside the Camel namespace and therefore not filtered by the default HeaderFilterStrategy) to CamelGoogle<Service><Name>, following the convention used across the rest of the Camel component catalog and matching the pattern established in CAMEL-23526 (camel-cxf), CAMEL-23522 (camel-mail), CAMEL-23461 (camel-aws-bedrock), CAMEL-23532 (camel-vertx-websocket / camel-atmosphere-websocket / camel-iggy), and CAMEL-23576 (camel-jira). Renamed values: - GoogleCloudFunctions: OPERATION, ENTRY_POINT, RUNTIME, SOURCE_ARCHIVE_URL, RESPONSE_OBJECT - GoogleSecretManager: OPERATION (SECRET_ID, VERSION_ID, REPLICATION were already Camel-prefixed) - GoogleCloudVision: OPERATION, RESPONSE_OBJECT - GoogleCloudTextToSpeech: OPERATION, RESPONSE_OBJECT - GoogleCloudSpeechToText: OPERATION, RESPONSE_OBJECT The Java field names are unchanged so routes referencing the constants symbolically continue to work; routes using the literal string values must be updated (documented in the 4.21 upgrade guide). The generated Endpoint DSL header accessor names are unchanged (the Camel prefix is stripped when deriving the accessor name); the accessors now return the new values. All existing tests use symbolic constant references and continue to pass. Tracker: CAMEL-23577 Reported by Claude Code on behalf of Andrea Cosentino Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the Exchange header string values in the five Google Cloud component
constant classes from their
GoogleCloud<Service>/GoogleSecretManagerprefixes — which sit outside the
Camelnamespace and are therefore notfiltered by the default
HeaderFilterStrategyat transport boundaries — toCamelGoogle<Service><Name>. This follows the convention used across the restof the Camel component catalog and matches the pattern established in
CAMEL-23526 (
camel-cxf), CAMEL-23522 (camel-mail), CAMEL-23461(
camel-aws-bedrock), CAMEL-23532 (camel-vertx-websocket/camel-atmosphere-websocket/camel-iggy), and CAMEL-23576 (camel-jira).GoogleCloudFunctionsConstants.OPERATIONGoogleCloudFunctionsOperationCamelGoogleCloudFunctionsOperationGoogleCloudFunctionsConstants.ENTRY_POINTGoogleCloudFunctionsEntryPointCamelGoogleCloudFunctionsEntryPointGoogleCloudFunctionsConstants.RUNTIMEGoogleCloudFunctionsRuntimeCamelGoogleCloudFunctionsRuntimeGoogleCloudFunctionsConstants.SOURCE_ARCHIVE_URLGoogleCloudFunctionsSourceArchiveUrlCamelGoogleCloudFunctionsSourceArchiveUrlGoogleCloudFunctionsConstants.RESPONSE_OBJECTGoogleCloudFunctionsResponseObjectCamelGoogleCloudFunctionsResponseObjectGoogleSecretManagerConstants.OPERATIONGoogleSecretManagerOperationCamelGoogleSecretManagerOperationGoogleCloudVisionConstants.OPERATIONGoogleCloudVisionOperationCamelGoogleCloudVisionOperationGoogleCloudVisionConstants.RESPONSE_OBJECTGoogleCloudVisionResponseObjectCamelGoogleCloudVisionResponseObjectGoogleCloudTextToSpeechConstants.OPERATIONGoogleCloudTextToSpeechOperationCamelGoogleCloudTextToSpeechOperationGoogleCloudTextToSpeechConstants.RESPONSE_OBJECTGoogleCloudTextToSpeechResponseObjectCamelGoogleCloudTextToSpeechResponseObjectGoogleCloudSpeechToTextConstants.OPERATIONGoogleCloudSpeechToTextOperationCamelGoogleCloudSpeechToTextOperationGoogleCloudSpeechToTextConstants.RESPONSE_OBJECTGoogleCloudSpeechToTextResponseObjectCamelGoogleCloudSpeechToTextResponseObjectThe Java field names are unchanged, so routes referencing the constants
symbolically continue to work; routes using the literal string values must be
updated (documented in the 4.21 upgrade guide).
Already-compliant constants left unchanged
GoogleSecretManagerConstants.SECRET_ID,VERSION_IDandREPLICATIONwerealready
Camel-prefixed (CamelGoogleSecretManagerSecretId, etc.).DSL accessors
The generated Endpoint DSL header accessor names are unchanged (e.g.
googleCloudFunctionsOperation()), because theCamelprefix is strippedwhen deriving the accessor name; the accessors now return the new
Camel-prefixed values.Backports
camel-google-functionsandcamel-google-secret-managerexist oncamel-4.18.xandcamel-4.14.xwith the same legacy values — backportapplies and will be filed as follow-up PRs.
camel-google-vision,camel-google-text-to-speechandcamel-google-speech-to-textwere added after the 4.18.x / 4.14.x branchpoints and do not exist on those branches — no backport for them.
Test plan
mvn testin each of the 5 modules — all passcomponents' regen artifacts included
Tracker: CAMEL-23577
Reported by Claude Code on behalf of Andrea Cosentino