CAMEL-23585: camel-arangodb - align Exchange header constant names with Camel naming convention#23469
Merged
Merged
Conversation
gnodet
approved these changes
May 22, 2026
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Clean, straightforward header-rename PR — same pattern that has been applied across several other components recently.
Verified:
- The two renamed header values (
key->CamelArangoDbKey,ResultClassType->CamelArangoDbResultClassType) are consistent with the existingCamelArangoDb*prefix used by the other six constants in the same class. - Java field names (
ARANGO_KEY,RESULT_CLASS_TYPE) are unchanged, so symbolic references compile without changes. - Tests all use the symbolic constants (static imports of
ARANGO_KEY,RESULT_CLASS_TYPE), so no test changes are needed — confirmed by grep. - Generated artifacts (
arangodb.jsonin both catalog and component,ArangoDbEndpointBuilderFactory.java) are updated consistently. - Upgrade guide entry is thorough: documents both constants, the old/new values, the endpoint DSL accessor renames, and explains that symbolic users are unaffected.
- Code style is consistent.
Minor note (non-blocking): The PR title references CAMEL-23585 but the PR body says "Tracker: CAMEL-23577". These are likely the parent tracker vs. the component-specific sub-task — just flagging in case the commit message should reference one or the other specifically.
LGTM.
Claude Code on behalf of Guillaume Nodet
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (10 modules)
|
…th Camel naming convention Renames the two Exchange header string values in ArangoDbConstants that were not in the Camel namespace (key, ResultClassType) to CamelArangoDb<Name>, following the convention used across the rest of the Camel component catalog and matching the pattern established in CAMEL-23526 (camel-cxf), CAMEL-23522 (camel-mail), CAMEL-23461 (camel-aws-bedrock), CAMEL-23532 (camel-vertx-websocket / camel-atmosphere-websocket / camel-iggy), and CAMEL-23576 (camel-jira). - ARANGO_KEY: "key" -> "CamelArangoDbKey" - RESULT_CLASS_TYPE: "ResultClassType" -> "CamelArangoDbResultClassType" The Java field names are unchanged so routes referencing the constants symbolically continue to work; routes using the literal string values must be updated (documented in the 4.21 upgrade guide). The remaining constants (MULTI_UPDATE, MULTI_INSERT, MULTI_DELETE, AQL_QUERY, AQL_QUERY_BIND_PARAMETERS, AQL_QUERY_OPTIONS) were already Camel-prefixed and are unchanged. The generated Endpoint DSL header accessors on ArangoDbHeaderNameBuilder have been renamed: key() -> arangoDbKey() and resultClassType() -> arangoDbResultClassType(). All existing tests use symbolic constant references and continue to pass. Tracker: CAMEL-23577 Reported by Claude Code on behalf of Andrea Cosentino Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the two Exchange header string values in
ArangoDbConstantsthat werenot in the
Camelnamespace (and therefore not filtered by the defaultHeaderFilterStrategy) toCamelArangoDb<Name>, following the convention usedacross the rest of the Camel component catalog and matching the pattern
established in CAMEL-23526 (
camel-cxf), CAMEL-23522 (camel-mail),CAMEL-23461 (
camel-aws-bedrock), CAMEL-23532 (camel-vertx-websocket/camel-atmosphere-websocket/camel-iggy), and CAMEL-23576 (camel-jira).ArangoDbConstants.ARANGO_KEYkeyCamelArangoDbKeyArangoDbConstants.RESULT_CLASS_TYPEResultClassTypeCamelArangoDbResultClassTypeThe Java field names are unchanged so routes referencing the constants
symbolically continue to work; routes using the literal string values must be
updated (documented in the 4.21 upgrade guide).
Already-compliant constants left unchanged
MULTI_UPDATE,MULTI_INSERT,MULTI_DELETE,AQL_QUERY,AQL_QUERY_BIND_PARAMETERS, andAQL_QUERY_OPTIONSwere alreadyCamel-prefixed.Generated artifacts
components/camel-arangodb/.../arangodb.json+ catalog mirrordsl/camel-endpointdsl/.../ArangoDbEndpointBuilderFactory.java— DSL headeraccessors renamed (
key()→arangoDbKey(),resultClassType()→arangoDbResultClassType())Backports
camel-arangodbexists oncamel-4.18.xandcamel-4.14.xwith the samelegacy values — backports apply and will be filed as follow-up PRs.
Test plan
mvn testincomponents/camel-arangodb— passescamel-arangodbregenartifacts included
=== camel-arangodbTracker: CAMEL-23577
Reported by Claude Code on behalf of Andrea Cosentino